Do not block pg_upgrade (skip check when IsBinaryUpgrade)#10
Open
thomas-bright wants to merge 1 commit into
Open
Do not block pg_upgrade (skip check when IsBinaryUpgrade)#10thomas-bright wants to merge 1 commit into
thomas-bright wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
eradman
reviewed
Jun 24, 2026
| #include "nodes/nodeFuncs.h" | ||
| #include "parser/analyze.h" | ||
| #include "utils/guc.h" | ||
| #include "miscadmin.h" |
Owner
There was a problem hiding this comment.
Move this import below #include "fmgr.h" (run make format to check)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9, addressing problem 2 from #8.
pg_upgrade issues catalog UPDATEs without a WHERE clause — e.g.
UPDATE pg_catalog.pg_database SET datfrozenxid = …— which safeupdate blocks, so the upgrade fails unless safeupdate is disabled first. These run while the server is in binary-upgrade mode, so skip the check whenIsBinaryUpgradeis set. The previous hook is still called (just above), so other extensions keep working during the upgrade.Verified: a plain PG17→PG18
pg_upgradethat fails with stock safeupdate (UPDATE requires a WHERE clause) completes with this change, safeupdate still enabled.No automated test — exercising it needs a real
pg_upgrade(two clusters), which doesn't fit thepg_tmpharness.Disclosure: I used an AI assistant to help investigate and draft this; I reproduced and verified it myself.