Skip to content

ci(workflows): add explicit permissions to GitHub Actions workflows#867

Merged
rnyb merged 2 commits into
mainfrom
wf-permission
Jun 8, 2026
Merged

ci(workflows): add explicit permissions to GitHub Actions workflows#867
rnyb merged 2 commits into
mainfrom
wf-permission

Conversation

@rnyb

@rnyb rnyb commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator
  • codecov and linting workflows: Set contents:read
  • subscript workflow: Introduces a new deploy-docs job, uploads/downloads a docs artifact, renames the main job (subscript -> test), and changes the Git push strategy

- Set contents:read for codecov and linting workflows
- Set contents:write for subscript workflow to enable write operations

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds explicit permissions blocks to GitHub Actions workflows to align with least-privilege defaults and enable required write operations.

Changes:

  • Add contents: write permissions to the subscript workflow (to support write operations like pushing to gh-pages).
  • Add contents: read permissions to the linting and codecov workflows.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/subscript.yml Adds workflow-level contents: write permissions.
.github/workflows/linting.yml Adds workflow-level contents: read permissions.
.github/workflows/codecov.yml Adds workflow-level contents: read permissions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/subscript.yml
@codecov-commenter

codecov-commenter commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.53%. Comparing base (258eebf) to head (123dd4e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #867   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files          49       49           
  Lines        7405     7405           
=======================================
  Hits         6260     6260           
  Misses       1145     1145           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/subscript.yml
Comment thread .github/workflows/subscript.yml
@rnyb rnyb force-pushed the wf-permission branch from 9ce0577 to 123dd4e Compare June 8, 2026 08:18
@rnyb rnyb requested review from alifbe and oyvindeide June 8, 2026 08:25
Comment thread .github/workflows/subscript.yml

@alifbe alifbe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@rnyb rnyb merged commit 1cb5961 into main Jun 8, 2026
10 checks passed
@rnyb rnyb deleted the wf-permission branch June 8, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants