Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/app-bridge/src/app-bridge.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,27 @@ describe('app-bridge', () => {
it('should timeout if no response received', async () => {
await expect(initialize({ timeout: 50 })).rejects.toThrow(AppBridgeTimeoutError);
});

it('should retry the handshake when the parent listener attaches late', async () => {
const initPromise = initialize({ timeout: 50 });

// Parent only becomes ready after the first attempt timed out
setTimeout(() => {
simulateParentMessage('app-bridge:init', { token: 'late-token', lang: 'de' });
}, 80);

await expect(initPromise).resolves.toEqual({ token: 'late-token', lang: 'de' });
expect(postMessageMock).toHaveBeenCalledTimes(2);
});

it('should reject after exhausting retries and allow initializing again', async () => {
await expect(initialize({ timeout: 20, retries: 1 })).rejects.toThrow(AppBridgeTimeoutError);
expect(postMessageMock).toHaveBeenCalledTimes(2);

const again = initialize({ timeout: 50 });
setTimeout(() => simulateParentMessage('app-bridge:init', { token: 't', lang: 'en' }), 10);
await expect(again).resolves.toEqual({ token: 't', lang: 'en' });
});
});

describe('getSession', () => {
Expand Down
12 changes: 12 additions & 0 deletions packages/app-bridge/src/messages.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,18 @@ describe('messages', () => {
expect(window.removeEventListener).toHaveBeenCalledWith('message', eventListener);
});

it('should ignore parent messages without an event name for wildcard suffix subscriptions', () => {
const handler = vi.fn();
subscribeToParentMessages('prefix-*', handler);

const eventListener = (window.addEventListener as Mock).mock.calls[0][1];

expect(() =>
eventListener(new MessageEvent('message', { data: { foo: 'bar' }, source: window.parent })),
).not.toThrow();
expect(handler).not.toHaveBeenCalled();
});

it('should subscribe to all events with *', () => {
const handler = vi.fn();
const unsubscribe = subscribeToParentMessages('*', handler);
Expand Down
2 changes: 1 addition & 1 deletion packages/app-bridge/src/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const subscribeToParentMessages = (event: string, handler: MessageHandler
if (
event === '*' ||
incomingEvent === event ||
(event.endsWith('*') && incomingEvent.startsWith(event.slice(0, -1)))
(event.endsWith('*') && typeof incomingEvent === 'string' && incomingEvent.startsWith(event.slice(0, -1)))
) {
handler(msgEvent);
}
Expand Down
Loading