Epic fft dft 2 - #36
Draft
adampbeardsley wants to merge 13 commits into
Draft
Conversation
…g buffer size. Added EPIC_multi_gpu.py to have two copies of fft_grid run on two GPUs simultaneously
…ing. It includes Matt's numpy speedups, fits file writing and Hari's optimizations
Closed
adampbeardsley
commented
Dec 15, 2021
Comment on lines
+1050
to
+1055
| #try: | ||
| # bf_romein.execute(udata, gdata) | ||
| #except NameError: | ||
| # bf_romein = Romein() | ||
| # bf_romein.init(self.locs, gphases, self.grid_size, polmajor=False) | ||
| # bf_romein.execute(udata, gdata) |
Author
There was a problem hiding this comment.
Remove block comments
Suggested change
| #try: | |
| # bf_romein.execute(udata, gdata) | |
| #except NameError: | |
| # bf_romein = Romein() | |
| # bf_romein.init(self.locs, gphases, self.grid_size, polmajor=False) | |
| # bf_romein.execute(udata, gdata) |
Comment on lines
+1149
to
+1154
| #bifrost.map( | ||
| # "a(i,j,k,l) += (b(i,j,k,l/2) * b(i,j,k,l%2).conj())", | ||
| # {"a": autocorrs, "b": udata, "t": self.ntime_gulp}, | ||
| # axis_names=("i", "j", "k", "l"), | ||
| # shape=(self.ntime_gulp, nchan, nstand, npol ** 2), | ||
| #) |
Author
There was a problem hiding this comment.
Suggested change
| #bifrost.map( | |
| # "a(i,j,k,l) += (b(i,j,k,l/2) * b(i,j,k,l%2).conj())", | |
| # {"a": autocorrs, "b": udata, "t": self.ntime_gulp}, | |
| # axis_names=("i", "j", "k", "l"), | |
| # shape=(self.ntime_gulp, nchan, nstand, npol ** 2), | |
| #) |
Comment on lines
+1166
to
+1171
| #bifrost.map( | ||
| # "a(i,j,p,k,l) += b(0,i,j,p/2,k,l)*b(0,i,j,p%2,k,l).conj()", | ||
| # {"a": crosspol, "b": gdata}, | ||
| # axis_names=("i", "j", "p", "k", "l"), | ||
| # shape=(self.ntime_gulp, nchan, npol ** 2, self.grid_size, self.grid_size), | ||
| #) |
Author
There was a problem hiding this comment.
Suggested change
| #bifrost.map( | |
| # "a(i,j,p,k,l) += b(0,i,j,p/2,k,l)*b(0,i,j,p%2,k,l).conj()", | |
| # {"a": crosspol, "b": gdata}, | |
| # axis_names=("i", "j", "p", "k", "l"), | |
| # shape=(self.ntime_gulp, nchan, npol ** 2, self.grid_size, self.grid_size), | |
| #) |
Comment on lines
+1198
to
+1205
| #try: | ||
| # bf_romein_autocorr.execute(autocorrs_av, autocorr_g) | ||
| #except NameError: | ||
| # bf_romein_autocorr = Romein() | ||
| # bf_romein_autocorr.init( | ||
| # autocorr_lo, autocorr_il, self.grid_size, polmajor=False | ||
| # ) | ||
| # bf_romein_autocorr.execute(autocorrs_av, autocorr_g) |
Author
There was a problem hiding this comment.
Suggested change
| #try: | |
| # bf_romein_autocorr.execute(autocorrs_av, autocorr_g) | |
| #except NameError: | |
| # bf_romein_autocorr = Romein() | |
| # bf_romein_autocorr.init( | |
| # autocorr_lo, autocorr_il, self.grid_size, polmajor=False | |
| # ) | |
| # bf_romein_autocorr.execute(autocorrs_av, autocorr_g) |
Comment on lines
+2210
to
+2213
| #if args.removeautocorrs: | ||
| # raise NotImplementedError( | ||
| # "Removing autocorrelations is not yet properly implemented." | ||
| # ) |
Author
There was a problem hiding this comment.
Why is this commented out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made another branch so I could merge main in and compare. I didn't want to mess up the deployed (epic_fft_dft) branch.