Separate bifrost module acorr calculates auto-correlations and is inc… - #20
Open
adampbeardsley wants to merge 1 commit into
Open
Separate bifrost module acorr calculates auto-correlations and is inc…#20adampbeardsley wants to merge 1 commit into
adampbeardsley wants to merge 1 commit into
Conversation
…luded in the epic_optim branch of bifrost in epic_astronomy repository. This module has been tested and is required to perform autocorrelation removal
adampbeardsley
commented
Jun 24, 2021
Comment on lines
+1153
to
+1158
| #bifrost.map( | ||
| # "a(i,j,k,l) += (b(i,j,k,l/2) * b(i,j,k,l%2).conj())", | ||
| # {"a": autocorrs, "b": udata, "t": self.ntime_gulp}, | ||
| # axis_names=("i", "j", "k", "l"), | ||
| # shape=(self.ntime_gulp, nchan, nstand, npol ** 2), | ||
| #) |
Author
There was a problem hiding this comment.
Suggested change
| #bifrost.map( | |
| # "a(i,j,k,l) += (b(i,j,k,l/2) * b(i,j,k,l%2).conj())", | |
| # {"a": autocorrs, "b": udata, "t": self.ntime_gulp}, | |
| # axis_names=("i", "j", "k", "l"), | |
| # shape=(self.ntime_gulp, nchan, nstand, npol ** 2), | |
| #) |
adampbeardsley
commented
Jun 24, 2021
Comment on lines
+2191
to
+2194
| #if args.removeautocorrs: | ||
| # raise NotImplementedError( | ||
| # "Removing autocorrelations is not yet properly implemented." | ||
| # ) |
Author
There was a problem hiding this comment.
Suggested change
| #if args.removeautocorrs: | |
| # raise NotImplementedError( | |
| # "Removing autocorrelations is not yet properly implemented." | |
| # ) |
adampbeardsley
commented
Jun 24, 2021
|
|
||
| # Setup the cores and GPUs to use | ||
| cores = [0, 2, 3, 4, 5, 6, 7] | ||
| #cores = [0, 2, 3, 4, 5, 6, 7] |
Author
There was a problem hiding this comment.
Suggested change
| #cores = [0, 2, 3, 4, 5, 6, 7] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…luded in the epic_optim branch of bifrost in epic_astronomy repository. This module has been tested and is required to perform autocorrelation removal