tracing: expose CEL config for HCM and routes#45947
Draft
kamalmarhubi wants to merge 2 commits into
Draft
Conversation
Add `cel_config` to `envoy.formatter.cel` configuration, allowing CEL runtime options to be enabled on a per-formatter basis. This is prerequisite work for envoyproxy#45420 and envoyproxy#45447: both are about enabling CEL string functions through formatter configuration, but the CEL formatter extension did not expose the underlying CEL expression runtime options. The built-in CEL parser still uses the active server context, so existing unconfigured CEL formatter command usage is unchanged. Signed-off-by: Kamal Al Marhubi <kamal@marhubi.com>
Tracing custom tags and operation names use formatter command parsers, but route tracing and HCM tracing had no place to configure them. Add scoped `formatters` fields and pass the parsed parsers through to custom tags, operation names, and upstream operation names. Built-in parsers such as `%CEL%` remain available when the field is empty. The new field is only needed for extension parsers or overrides such as CEL string functions. Fixes envoyproxy#45447 Signed-off-by: Kamal Al Marhubi <kamal@marhubi.com>
|
Hi @kamalmarhubi, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
kamalmarhubi
requested a deployment
to
external-contributors
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is stacked on top of #45934. The top commit is the incremental diff.
Commit Message:
tracing: expose CEL config for HCM and routes
Tracing custom tags and operation names use formatter command parsers, but route tracing and HCM tracing had no place to configure them. Add scoped
formattersfields and pass the parsed parsers through to custom tags, operation names, and upstream operation names.Built-in parsers such as
%CEL%remain available when the field is empty. The new field is only needed for extension parsers or overrides such as CEL string functions.Fixes #45447
Additional Description: See #45447 for motivation: enabling CEL string functions in tracing custom tags and operation names.
AI Disclosure: This was developed by iterating with OpenAI Codex (GPT-5.5), with review and further iteration using Claude Code (Opus 4.8). I reviewed and edited the generated output, understand the submitted changes, and take responsibility for them.
Risk Level: Low
Testing:
Docs Changes: Inline proto documentation for the new
formattersfields.Release Notes: Added (tracing).
Platform Specific Features: N/A.
API Considerations: adds
formatters(repeated core.v3.TypedExtensionConfig) to route tracing and HCM tracing configuration. This is additive; omitting it preserves existing behaviour.