Skip to content

config: adds GrpcMux tests with xds config tracker and resources delegate#45930

Open
birenroy wants to merge 3 commits into
envoyproxy:mainfrom
birenroy:xds-config-tracker-tests
Open

config: adds GrpcMux tests with xds config tracker and resources delegate#45930
birenroy wants to merge 3 commits into
envoyproxy:mainfrom
birenroy:xds-config-tracker-tests

Conversation

@birenroy

@birenroy birenroy commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Adds unit tests that integrate a XdsConfigTracker and XdsResourcesDelegate in both SotW (GrpcMuxImpl) and Delta (NewGrpcMuxImpl) implementations.

Verifies that:

  • onConfigAccepted/onConfigRejected are called on XdsConfigTracker.
  • getResources/onConfigUpdated/onResourceLoadFailed are called on XdsResourcesDelegate (SotW only).

I used the Gemini AI model to write these test cases.

Commit Message:
Additional Description:
Risk Level: none
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

birenroy added 2 commits July 1, 2026 20:14
…legate

Add integration tests for XdsConfigTracker and XdsResourcesDelegate in
both SotW (GrpcMuxImpl) and Delta (NewGrpcMuxImpl) implementations.

Verify that:
- onConfigAccepted/onConfigRejected are called on XdsConfigTracker.
- getResources/onConfigUpdated/onResourceLoadFailed are called on XdsResourcesDelegate (SotW only).

TAG=agy
CONV=b942214e-2f01-4571-9478-b3eda0877a4c

Signed-off-by: Biren Roy <birenroy@google.com>
…d mocks

Move MockXdsConfigTracker and MockXdsResourcesDelegate from local test
files to test/mocks/config/mocks.h to allow reuse and avoid duplication.
Update BUILD dependencies accordingly.

TAG=agy
CONV=b942214e-2f01-4571-9478-b3eda0877a4c

Signed-off-by: Biren Roy <birenroy@google.com>
@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #45930 was opened by birenroy.

see: more, trace.

…tests

Signed-off-by: Biren Roy <birenroy@google.com>
@birenroy birenroy changed the title config: adds integration tests for xds config tracker and resources delegate config: adds GrpcMux tests with xds config tracker and resources delegate Jul 2, 2026
@birenroy birenroy marked this pull request as ready for review July 2, 2026 01:09
@birenroy

birenroy commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/assign @adisuissa

I'm adding some test coverage in advance of #45898.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants