listener: implement support for multiple API listeners in Envoy native#45919
Open
paul-r-gall wants to merge 1 commit into
Open
listener: implement support for multiple API listeners in Envoy native#45919paul-r-gall wants to merge 1 commit into
paul-r-gall wants to merge 1 commit into
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
- Refactors ListenerManagerImpl to use a map of API listeners instead of a single instance. - Adds apiListener(name) lookup method. - Modifies addOrUpdateListenerInternal to support adding multiple listeners via bootstrap, returning false if added_via_api to retain future LDS compatibility. - Updates unit tests to verify multiple listener behaviors. Signed-off-by: Paul Ogilby <pgal@google.com>
0984893 to
70c96e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: listener: implement support for multiple API listeners in Envoy native
Additional Description:
One of the goals here is to get to a point where we can use API Listeners instead of Internal Listeners for some cases. Upcoming PR implements "loopback to API Listener".
Risk Level: low
Testing: unit, integration
Docs Changes: comment changes in listener.proto.
Release Notes: yes
AI Usage: yes, and I stand by the changes.