http: replace per-request ODCDS filter virtual dispatch with variant#45917
Open
akonradi wants to merge 1 commit into
Open
http: replace per-request ODCDS filter virtual dispatch with variant#45917akonradi wants to merge 1 commit into
akonradi wants to merge 1 commit into
Conversation
akonradi
force-pushed
the
odcds-filter-less-virtual-dispatch
branch
from
f6c8998 to
cb6082b
Compare
akonradi
changed the title
Make DecodeHeadersBehavior a thin wrapper around an absl::variant<Rds, CdsRds> and dispatch decodeHeaders via absl::visit instead of a virtual call, avoiding the vtable indirection on the decode-headers hot path. Signed-off-by: Alex Bakon <abakon@netflix.com>
akonradi
force-pushed
the
odcds-filter-less-virtual-dispatch
branch
from
cb6082b to
7912d3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Make DecodeHeadersBehavior a thin wrapper around a variant<Rds, CdsRds> and dispatch decodeHeaders via visit instead of a virtual call, avoiding the vtable indirection on the decode-headers hot path.
Additional Description:
This also removes one heap allocation on filter construction. It does so by moving storage inline into the filter.
This change was implemented with AI but is approximately what I would have written myself.
Risk Level: low
Testing: ran unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A