upstream: set IP_BIND_ADDRESS_NO_PORT when bind port is 0#45916
Open
404SkillNotFound wants to merge 3 commits into
Open
upstream: set IP_BIND_ADDRESS_NO_PORT when bind port is 0#45916404SkillNotFound wants to merge 3 commits into
404SkillNotFound wants to merge 3 commits into
Conversation
Signed-off-by: 404SkillNotFound <shivang.upadhyay1@gmail.com>
Signed-off-by: 404SkillNotFound <shivang.upadhyay1@gmail.com>
Signed-off-by: 404SkillNotFound <shivang.upadhyay1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
upstream: set IP_BIND_ADDRESS_NO_PORT for upstream_bind_config
Additional Description:
Automatically enable IP_BIND_ADDRESS_NO_PORT when upstream_bind_config binds
to a source IP with port 0. This defers ephemeral port allocation until
connect() and helps prevent ephemeral port exhaustion.
Risk Level:
Low
Testing:
Unit test
Docs Changes:
N/A
Release Notes:
Added changelog fragment.
Platform Specific Features:
Linux
[Optional Runtime guard:]
envoy.reloadable_features.upstream_bind_config_fix_port_exhaustion
[Optional Fixes #Issue]
Fixes #44747
[Optional Fixes commit #PR or SHA]
Builds on the approach used in #38288 and the earlier work in #44837.
[Optional Deprecated:]
N/A
[Optional API Considerations:]
N/A