ts: ignore Spack warning lines in source-sh install tests - #703
Open
xdelaruelle wants to merge 1 commit into
Open
xdelaruelle wants to merge 1 commit into
xdelaruelle wants to merge 1 commit into
Conversation
Spack reports on stderr the warnings raised when loading its package repository, for instance the syntax warning emitted by Python 3.12+ over an invalid escape sequence in a package file. Such a warning, introduced by the krona package, makes the bash source-sh test case fail on the tcl91 CI job, the only one running with a recent Python version. These warnings are unrelated to what is tested here, so drop the "==> Warning:" lines from stderr before comparing it against the expected output of the Spack test cases. Assisted-by: Claude:claude-fable-5-1 Signed-off-by: Xavier Delaruelle <xavier.delaruelle@cea.fr>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spack reports on stderr the warnings raised when loading its package repository, for instance the SyntaxWarning that Python 3.12+ emits over the invalid escape sequence in the recently added
kronapackage (see spack/spack-packages#6525, fix proposed in spack/spack-packages#6526). It makes the bash source-sh test case fail on the tcl91 CI job, the only one running with a recent Python version.These warnings are unrelated to what the source-sh tests check, so the
==> Warning:lines are now dropped from stderr before comparison for the Spack test cases.