Return guesses as Float for empty password#119
Merged
Conversation
Non-empty passwords return Float through the DP scoring path. Empty password short-circuits with an Integer 1, producing a type inconsistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Zxcvbn.test('')returnsguesses: 1(Integer). All other passwords go through the DP scoring path and returnguessesas Float. The JS library also returns1for empty password, so the value is correct — only the Ruby type is inconsistent.Changes
Change the empty-password short-circuit in
Scorer#most_guessable_match_sequencefrom1to1.0.Consequences
guessesis now consistently Float across all inputs.