Adjust publishing to manual - #52
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR shifts release publishing from an automatic push-to-main trigger to a manually triggered workflow, and adds a dedicated main-branch verification workflow with Slack notifications.
Changes:
- Added a
Verify mainworkflow that runs Gradle verification on pushes tomainand posts success/failure to Slack. - Updated the main deploy workflow to run via
workflow_dispatchwith a selectable version increment and tag-based versioning.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/main-verify.yml | New main-branch verification workflow using reusable Gradle verify + Slack notifications. |
| .github/workflows/deploy-main-manual-gradle.yml | Converts deploy to manual trigger with version increment input; updates publish job and Slack notifications accordingly. |
Suppressed comments (2)
.github/workflows/deploy-main-manual-gradle.yml:23
workflow_dispatchinput id contains a hyphen (version-increment), but the expression uses dot notation (inputs.version-increment). In GitHub Actions expressions, keys with hyphens must be accessed with bracket notation (otherwise it can be parsed as subtraction), which will breaknext_versionresolution.
.github/workflows/deploy-main-manual-gradle.yml:17- This workflow is now manually triggerable from any ref. Since it publishes to Maven Central and is named "from main", consider enforcing that the publish job only runs on
refs/heads/mainto prevent accidental releases from feature branches.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.