fix(mirror): reconcile stale solved issue links#96
Draft
JSONbored wants to merge 1 commit into
Draft
Conversation
Clear solved_by_pr links that still point to a refreshed PR when its closing references change or it is no longer merged, then reapply current merged links. Fixes entrius#59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issues.solved_by_prwhenever PR metadata is refreshed.What changed
handlePrMetadata()now records the previous closing issue set before fetching fresh metadata.solved_by_prstill points at the refreshed PR, so links already moved to another PR are preserved.Why
solved_by_prwas previously write-only on merged PR metadata refreshes. If a merged PR body was edited to remove or change a closing reference, the old issue row could remain permanently linked to that PR and downstream scoring/API views could attribute the issue to the wrong solver.Fixes #59
Validation
npm cinpm run buildnpm run lintnpm run format:checkgit diff --checkNotes