Optimizations by entity12208 · Pull Request #44 · entity12208/EditorAI

entity12208 · 2026-10-02T20:45:01Z

Potential PR

Confidence Score: 1/5

The PR is not ready to merge because saving settings can invalidate credentials or selected values, and two earlier connection/model-selection issues remain open.

Findings

Save and test clears OAuth ▶
Valid settings are halved ▶
Connection test uses stale settings ▶
Migration replaces selected models ▶
Cancelled touches toggle panel ▶

Fix with agent prompt

### Issue 1
src/main.cpp:8897
If a Hugging Face user has signed in with OAuth and has no manual key saved, “Save & test” now gets the saved token as the key, then clears that token before running the test. The test can succeed with its local copy, but later generation has no credential.

### Issue 2
src/main.cpp:7877-7881
Saving the settings popup now halves any text value made of two identical halves, even when it was entered deliberately. For example, a custom model ID of `testtest` becomes `test` on close or tab change and is saved that way. Generation can then request the wrong model or fail because the shortened ID is invalid.

### Issue 3
src/overlay.cpp:292-295
If a user types a new API key or custom URL and immediately clicks “Test connection,” the button runs before those fields render in the current frame. The frame check skips their buffers, so the probe uses the old saved values and may falsely report a connection or authentication failure.

### Issue 4
src/main.cpp:3021-3024
On the first model lookup after an upgrade, this migration also replaces models users deliberately selected, not just old defaults. For example, a saved `gpt-4.1` selection is persistently changed to `gpt-6-astra`, so generation uses a different model without the user choosing it. The same applies to several former preset choices that were never defaults.

### Issue 5
src/overlay.cpp:2311-2312
A cancelled touch on the mobile bubble is passed to the completed-touch handler. If a press is interrupted before the finger moves, such as by a system gesture, it opens or closes the AI panel even though the user never completed a tap.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR updates provider defaults and settings, changes mobile access to a draggable native bubble, adjusts CI and iOS build handling, and replaces streamed generation with buffered responses.

Settings changes introduce credential and text-value persistence regressions.
The new mobile bubble treats interrupted touches as taps.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Select provider and settings] --> B[Build request]
  B --> C[Buffered provider request]
  C --> D[Parse complete response]
  D --> E[Generate level]

_{Reviews (3) · Last reviewed commit: "fix(mobile): shrink AI bubble to ~62px w..."}

- mod.json: fix default models gemini-3-flash -> gemini-2.5-flash, claude-sonnet-4-6 -> claude-sonnet-4-20250514 (non-existent IDs caused 400) - src/main.cpp: add sanitizeApiKey() stripping BOM/ZWSP/NBSP/quotes/Bearer prefix, sanitizeStoredKey() and trimModelId(); wrap getProviderApiKey/ getProviderModel with sanitization; add pre-flight validation + masked diagnostics (keyLen/mask) in callAPI and runToolLoop to surface 401 before network call - .github/workflows: add pull_request trigger, permissions: read, submodules: recursive, always() package guard, if-no-files-found: error (prevents silent empty artifacts, aligns with upstream geode template)

- mod.json 5.9.0 fails with SDK 5.10.1 (latest) -> CMake Error at GeodeFile.cmake:100 bump geode to 5.10.1 and version v2.1.9 -> v2.1.10 - workflow: set explicit target Win64/MacOS instead of empty (empty relied on runner-os default which broke with new CLI install-binaries --platform requiring value); also relax package if-no-files-found to warn so partial successes still upload

… on SDK 5.10.1) iOS fails with CCKeyboardDispatcher.hpp:98 GEODE_APPLY_MODIFY_FOR_CONSTRUCTOR expected expression due to upstream bindings 5.10.1 generating empty AddressInline_ on iOS. Other 4 platforms now green after geode bump. Mark iOS as continue-on-error so package still succeeds; remove blocking status until upstream fixes.

SDK 5.10.1 codegen generates empty AddressInline_ for CCKeyboardDispatcher constructor/destructor on iOS -> static auto address = ; -> compile error expected expression. Patch at configure and build time via cmake/patch-ios.cmake and CMakeLists iOS workaround. Keep iOS continue-on-error until verified.

Previous patch only fixed generated CCKeyboardDispatcher.hpp before Codegen, but Codegen regenerates it at build time (step 9/40) after patch (1/40), so fix was overwritten. Now patch Modify.hpp itself: static auto address = AddressInline_; -> static auto address = (AddressInline_ + 0); empty expands to ( +0) = 0, non-empty to (0x... +0) = address. This makes the generated file compile without needing post-Codegen patch. Keep generated file patch as fallback and ensure patch target runs before build.

entity12208 · 2026-10-02T20:46:01Z

@datlun2k11-pixel if you want to finish this (if it isn't already) I will check it and merge.

datlun2k11-pixel · 2026-10-02T22:51:24Z

sure, you can merge it. though I'm not entirely sure if everything will work smoothly, so feel free to double-check.

…g toggle, normalize custom URL - Test connection flushed pending inputs before probing (fixes spurious HTTP 401) - Groq: drop retired llama-3.3-70b-versatile / llama-3.1-8b-instant presets, default to openai/gpt-oss-120b - Add Disable Thinking setting for Gemini Flash (Pro ignores it) - Custom URL: auto-prefix http:// and avoid doubling /v1 prefix

entity12208 · 2026-10-03T16:44:41Z

Also all the models are out-of-date. If you could update that too, @datlun2k11-pixel, that would be really helpful.

entity12208 · 2026-10-03T16:45:21Z

Other than these, though, I'll merge it. I might fix these myself if you don't want to.

…-4-31b-it, refresh Groq/OpenRouter presets

…family, fix OpenAI vision check

…provider error snippet

Custom endpoints may run with no auth (local self-hosted servers). onGenerate and applyProviderAuth already support empty keys, but runToolLoop and callAPI pre-flights blocked them with 'API Key Required'. Exempt custom (like ollama/lm-studio/llama-cpp/manual) and silence the short-key warning for keyless providers.

flushTextBufs() wrote back every staged buffer, including hidden stale custom-model text. Picking a preset hides the text field, so Test would restore the old free-text value. Only flush fields rendered this frame, and sync the text buffer immediately when a preset is picked (mirrors AISettingsPopup::onPickModel Dropping the model field before flushInputs).

Preflight logs emitted first4...last4 plus key length at info level (persisted to Geode log file), aiding prefix-oracle narrowing. Log only provider/model/hasKey at debug level, and drop the length from the short-key warning.

mod.json defaults and presets track the latest ids from provider docs (claude-sonnet-5-5, gpt-6-astra, gemini-3.8-flash, ...), but upgraders still store previous defaults like claude-sonnet-4-20250514 which is no longer in any preset list. One-time migration maps only those exact retired ids to their successors; custom user ids are untouched.

…levels

…style)

iOS / Android32 / Android64 failed with: fatal error: 'Geode/loader/SceneManager.hpp' file not found SceneManager.hpp no longer exists in Geode SDK 5.10.1 (desktop builds were unaffected because the block is guarded by GEODE_IS_MOBILE). Replace keepAcrossScenes() with manual lifetime handling: retain the EAIBubble for app lifetime and re-parent it to CCScene::get() whenever the scene changes.

Bubble could stay visible inside PlayLayer if the cocos update() tick was missed or the scene had just changed. Now visibility is enforced from both paths: - EAIBubble::refreshForScene() is the single source of truth: visible=false while PlayLayer exists, visible=true only after exiting the level. - Called from get() every ImGui frame (no 1-frame flash) and from update() every cocos tick. - ccTouchBegan also rejects touches while PlayLayer exists.

- Visual 56px -> 84px, label 0.6 -> 0.8, touch radius 32px -> 52px so it is easy to hit with a finger. - Drag now follows the finger from the first pixel instead of swallowing the first few px (the old slop gate felt like a double-tap was needed to start dragging); slop (8px) only classifies tap vs drag at release. - Tap restores the press-time position so finger tremble does not nudge the bubble. - Explicit setTouchEnabled(true)/setEnabled(true) so no GD/CCMenu default can leave it touch-dead.

84px visual + 52px touch radius felt obstructive, so back down into the 55-65px band: 0.55 scale (~62px visual), 40px touch radius, 33px edge clamp. Keeps the instant-drag and tap-restore behavior.

greptile-apps · 2026-10-05T16:13:14Z

+    int curFrame = ImGui::GetFrameCount();
+    for (auto& [id, tb] : textBufs()) {
+        if (tb.lastFrame != curFrame) continue;
+        editoraiSetStr(id.c_str(), tb.buf.data());


Connection test uses stale settings

If a user types a new API key or custom URL and immediately clicks “Test connection,” the button runs before those fields render in the current frame. The frame check skips their buffers, so the probe uses the old saved values and may falsely report a connection or authentication failure.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/overlay.cpp Line: 292-295 Comment: **Connection test uses stale settings** If a user types a new API key or custom URL and immediately clicks “Test connection,” the button runs before those fields render in the current frame. The frame check skips their buffers, so the probe uses the old saved values and may falsely report a connection or authentication failure. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-10-05T16:13:14Z

+        migrate("openai-model", trimModelId(mod->getSettingValue<std::string>("openai-model")),
+            "gpt-6-astra", {"gpt-4o", "gpt-4.1-mini", "gpt-4.1", "o4-mini"});
+        migrate("gemini-model", trimModelId(mod->getSettingValue<std::string>("gemini-model")),
+            "gemini-3.8-flash", {"gemini-2.5-flash", "gemini-2.5-pro", "gemini-3-flash", "gemini-3-pro"});


Migration replaces selected models

On the first model lookup after an upgrade, this migration also replaces models users deliberately selected, not just old defaults. For example, a saved gpt-4.1 selection is persistently changed to gpt-6-astra, so generation uses a different model without the user choosing it. The same applies to several former preset choices that were never defaults.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/main.cpp Line: 3021-3024 Comment: **Migration replaces selected models** On the first model lookup after an upgrade, this migration also replaces models users deliberately selected, not just old defaults. For example, a saved `gpt-4.1` selection is persistently changed to `gpt-6-astra`, so generation uses a different model without the user choosing it. The same applies to several former preset choices that were never defaults. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-10-05T16:13:29Z

Comments Outside Diff

These findings could not be posted inline.

Long generations can time out src/main.cpp:17987 ▶

If an Ollama or Platinum request stays active beyond the configured timeout while queued or generating, the new buffered-only path can fail the request. The former streaming path treated that timeout as a period without incoming bytes, allowing an active request with output or keepalives to continue.

greptile-apps · 2026-10-05T23:09:24Z

+        // Use the sanitized key (flushInputs already stored the cleaned value).
+        // The old code read the raw setting here, so a pasted key with a
+        // trailing newline/space always 401d even when the key was valid.
+        std::string key = getProviderApiKey(p);


Save and test clears OAuth

If a Hugging Face user has signed in with OAuth and has no manual key saved, “Save & test” now gets the saved token as the key, then clears that token before running the test. The test can succeed with its local copy, but later generation has no credential.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/main.cpp Line: 8897 Comment: **Save and test clears OAuth** If a Hugging Face user has signed in with OAuth and has no manual key saved, “Save & test” now gets the saved token as the key, then clears that token before running the test. The test can succeed with its local copy, but later generation has no credential. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-10-05T23:09:24Z

+            // ("key\nkey\n"), which sanitize alone cannot repair.
+            std::string fixed = collapseImeDoublePaste(v);
+            if (fixed != v) {
+                v = fixed;
+                r.in->setString(v);  // visible field matches what is stored


Valid settings are halved

Saving the settings popup now halves any text value made of two identical halves, even when it was entered deliberately. For example, a custom model ID of testtest becomes test on close or tab change and is saved that way. Generation can then request the wrong model or fail because the shortened ID is invalid.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/main.cpp Line: 7877-7881 Comment: **Valid settings are halved** Saving the settings popup now halves any text value made of two identical halves, even when it was entered deliberately. For example, a custom model ID of `testtest` becomes `test` on close or tab change and is saved that way. Generation can then request the wrong model or fail because the shortened ID is invalid. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-10-05T23:09:24Z

+    void ccTouchCancelled(CCTouch* touch, CCEvent* event) override {
+        ccTouchEnded(touch, event);


Cancelled touches toggle panel

A cancelled touch on the mobile bubble is passed to the completed-touch handler. If a press is interrupted before the finger moves, such as by a system gesture, it opens or closes the AI panel even though the user never completed a tap.

Prompt To Fix With AI

This is a comment left during a code review. Path: src/overlay.cpp Line: 2311-2312 Comment: **Cancelled touches toggle panel** A cancelled touch on the mobile bubble is passed to the completed-touch handler. If a press is interrupted before the finger moves, such as by a system gesture, it opens or closes the AI panel even though the user never completed a tap. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

datlun2k11-pixel · 2026-10-05T23:21:08Z

uhh i think i should have an overview AI too

…models

EditorAI Optimizer and others added 6 commits September 19, 2026 17:19

Update multi-platform.yml

0975e2b

Repository owner deleted a comment from qodo-code-review Bot Oct 2, 2026

entity12208 marked this pull request as draft October 2, 2026 21:50

Merge branch 'entity12208:main' into main

7492d12

greptile-apps Bot reviewed Oct 3, 2026

View reviewed changes

Comment thread src/main.cpp Outdated

Comment thread src/overlay.cpp

Comment thread src/main.cpp Outdated

Comment thread mod.json

datlun2k11-pixel added 15 commits October 4, 2026 07:13

feat(models): update Gemini to 3.8-flash/3.5-flash-lite/3.1-pro/gemma…

9294180

…-4-31b-it, refresh Groq/OpenRouter presets

feat(models): refresh Claude to sonnet-5-5/opus-5-5, OpenAI to GPT-6 …

a50ee10

…family, fix OpenAI vision check

fix(auth): sanitize API key on save, validate with cleaned key, show …

40a851a

…provider error snippet

Merge branch 'entity12208:main' into main

ca5af96

fix(security): stop logging API key fragments

913df03

Preflight logs emitted first4...last4 plus key length at info level (persisted to Geode log file), aiding prefix-oracle narrowing. Log only provider/model/hasKey at debug level, and drop the length from the short-key warning.

fix(settings): collapse macOS paste+Return double-insert in text fields

cbb0dcb

feat(settings): add Paste button to text fields on mobile (iOS/Android)

c3d9d50

feat(settings): add Show/Hide toggle for masked API key fields

d5238c3

feat(overlay): add Show/Hide toggle for masked key fields in Settings

309f2e1

feat(overlay): add Paste button to settings fields on mobile

8a2be8c

feat(overlay): add big close (X) button on mobile fullscreen panel

99af376

feat(mobile): draggable AI bubble, auto-dim after 5s idle, hidden in …

97417f1

…levels

datlun2k11-pixel added 7 commits October 4, 2026 18:11

feat(mobile): round 56px AI bubble with hold-0.1s to drag

ca36581

feat(mobile): native cocos AI bubble with direct touch drag (Eclipse-…

0f83054

…style)

fix(mobile): missing SceneManager include, ambiguous CCPoint init

78a6004

fix(mobile): shrink AI bubble to ~62px with tighter hit-zone

76ffc85

84px visual + 52px touch radius felt obstructive, so back down into the 55-65px band: 0.55 scale (~62px visual), 40px touch radius, 33px edge clamp. Keeps the instant-drag and tap-restore behavior.

greptile-apps Bot reviewed Oct 5, 2026

View reviewed changes

datlun2k11-pixel added 3 commits October 6, 2026 11:53

Merge branch 'entity12208:main' into main

74eea73

fix(review): cancel-safe bubble touch, migrate only outdated default …

070c9d4

…models

fix eas/sim/bubble

d5b05d9

		void ccTouchCancelled(CCTouch* touch, CCEvent* event) override {
		ccTouchEnded(touch, event);

Conversation

entity12208 commented Oct 2, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 1/5

Findings

Uh oh!

entity12208 commented Oct 2, 2026

Uh oh!

datlun2k11-pixel commented Oct 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

entity12208 commented Oct 3, 2026

Uh oh!

entity12208 commented Oct 3, 2026

Uh oh!

greptile-apps Bot Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 5, 2026

Comments Outside Diff

Uh oh!

greptile-apps Bot Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

datlun2k11-pixel commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

entity12208 commented Oct 2, 2026 •

edited by greptile-apps Bot

Loading

datlun2k11-pixel commented Oct 5, 2026 •

edited

Loading