Repository navigation
Fix the fifth security review's findings - #89
Merged
Merged
Conversation
entity
force-pushed
the
fix/security-audit-findings
branch
4 times, most recently
from
November 18, 2026 00:10
1a535a8 to
20dce8f
Compare
…emove codes an undone email change leaves nothing to recover
… the user fails, and refuse a password bcrypt can't hash, replacing the test that pinned the throw
…ing::result(), moving the test that read the plain flash
…ked, while its session is still signed in
…or names valid utf-8
entity
force-pushed
the
fix/security-audit-findings
branch
from
November 18, 2026 01:34
20dce8f to
efdc8d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the fifth security review, one commit per item. Each commit has its regression tests and updates
docs/andCHANGELOG.mdwhere the behaviour changed.keyring.freshonly counts a recovery code beside another factor. Undoing an email change also removes recovery codes once nothing is left for them to recover, and a recovery code no longer counts as an established second factor for skipping the current address's confirmation.create()throws is reported and answered like a taken address, with nothing sent.RegistrationTesthad a test that pinned the old throw; it now checks the uniform answer and the report. Withreveal_takenon, it still throws.keyring.result) is now encrypted. Pages read it with the newKeyring::result(). This changes the front-end contract:session('keyring.result')now holds ciphertext. The Inertia example, the docs andUPGRADE.mdare updated, andpublic-api.jsongainsresult.current_passwordwas checked against, and only while the session is still signed in. The app's action now runs inside that transaction (documented).namewhenever it's saved through it (import, a modelupdate(), custom factors).Testing
Ran
vendor/bin/pest,pint --test,phpstan analyseandrector --dry-runat every commit.