Skip to content

Close the third standards check's gaps and default to a second factor - #84

Merged
entity merged 2 commits into
mainfrom
fix/standards-third-pass
Nov 11, 2026
Merged

entity merged 2 commits into
mainfrom
fix/standards-third-pass

Conversation

@entity

@entity entity commented Nov 11, 2026

Copy link
Copy Markdown
Owner

What the third pass against OWASP ASVS 5.0.0, the cheat sheets and NIST SP 800-63B-4 found, fixed.

Behaviour

  • keyring:install now defaults to an authenticator app that every user must set up (ASVS 6.3.3, and Fortify offers 2FA out of the box). --factor=none, or unticking it, gives the password alone.
  • Keyring's own risk response emails the owner about a sign in after several failures or a long quiet period (ASVS 6.3.5). Before, each alone only asked for a second factor, which a password-only user doesn't have.
  • A session that "remember me" carries on is logged as session_resumed, with a SessionResumed event. It was the one way a browser got signed in with nothing in the log.
  • Keyring's responses send Cross-Origin-Opener-Policy: same-origin-allow-popups unless the app sends its own (ASVS 3.4.8).
  • The installer says when the app hashes with bcrypt, which refuses passwords over 72 bytes (ASVS 6.2.9).

Docs

  • The eight corrections the reports listed, and the pages that described a default install as password-only.

Left as documented deviations: the TOTP window of one step (6.5.5), NFC normalisation (6.2.8), and a disabled account's sessions ending at next use (7.4.2).

GitHub Actions can't start jobs on this account right now (billing), so I ran each job locally: SQLite 1,679 passed, PostgreSQL 1,704 + 11 concurrency, lowest dependencies 1,704, Pint, Rector and both PHPStan configs clean. MySQL is noted in a comment.

@entity
entity merged commit dcc4dc4 into main Nov 11, 2026
0 of 5 checks passed
@entity
entity deleted the fix/standards-third-pass branch November 11, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant