Skip to content

Fix what installing the example app turned up - #81

Merged
entity merged 1 commit into
mainfrom
fix/example-app-findings
Nov 11, 2026
Merged

entity merged 1 commit into
mainfrom
fix/example-app-findings

Conversation

@entity

@entity entity commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Four things the example app ran into on the latest main:

  • The pages emailed links open shared the six-a-minute form limit with their buttons, so opening both ends of an email change could use up the attempts. They now have their own limiter, keyring-pages (60 a minute per IP). The buttons keep keyring.
  • The email-change page's url prop was an absolute URL while the other three pages give a path. It's a path now.
  • EmailCode::asSecondFactor() is renamed asExtraStep(), since an emailed code no longer counts as a second factor.
  • Running keyring:install again on an app that has some of the migrations now adds the ones it's missing, rather than none.

Docs updated for each, plus a note that a re-run doesn't register new notifications in an existing provider.

Tested on SQLite (parallel), PostgreSQL (serial) and the race tests.

@entity
entity merged commit e61918d into main Nov 11, 2026
5 checks passed
@entity
entity deleted the fix/example-app-findings branch November 11, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant