Repository navigation
Close out the second standards check and make the docs true of the code - #80
Merged
Merged
Conversation
…the first refused request
…is found in a breach
…ous activity and undone email change notices by default
…-4 and the cheat sheets
…ion with its reason
…at the package now does
…ds on older carbon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes what the second check against OWASP ASVS 5.0.0, NIST SP 800-63B-4 and the OWASP cheat sheets still found open, and corrects every statement the docs make about those standards.
Code (one commit each, with tests)
allowSignInWhen()keeps out ends all of that account's sessions, once (ASVS 7.4.2).Requirement::factors(2)is still any two kinds.BreachedPasswordfinds theirs (NIST 3.1.1.2).support_contact: one setting, passed to every notification, shown in the published notices (NIST 4.6).rate_limited, through a newRateLimitedevent (ASVS 16.3.3).present()givescreatedAtandlastUsedAt, kept off the challenge page.throttle.Docs
docs/owasp-asvs.mdis rewritten from the code: the three ASVS levels, every V6 and V7 requirement, the requirements in other chapters that bear on the package, what Keyring's AAL1 to AAL3 mean in NIST's terms, and the cheat sheet recommendations that depend on setup.docs/security.md: the Standards table has the right document, section and revision for each row, and Known Limitations states each deviation once with its reason.CHANGELOG.mdbrought up to what the package does.To test
composer check, and injs/:bun run typecheck && bun test.StandardsDocsTestpins what the ASVS page says about a default install to the config and the installer.Not for merging yet: the example app needs a few changes for this, listed in the hand-over.