Skip to content

Close out the second standards check and make the docs true of the code - #80

Merged
entity merged 21 commits into
mainfrom
feat/standards-close-out
Nov 11, 2026
Merged

entity merged 21 commits into
mainfrom
feat/standards-close-out

Conversation

@entity

@entity entity commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Closes what the second check against OWASP ASVS 5.0.0, NIST SP 800-63B-4 and the OWASP cheat sheets still found open, and corrects every statement the docs make about those standards.

Code (one commit each, with tests)

  • The first request refused for an account allowSignInWhen() keeps out ends all of that account's sessions, once (ASVS 7.4.2).
  • AAL2 needs a factor the user has (NIST 2.2.1). Requirement::factors(2) is still any two kinds.
  • Keyring's own risk response holds a user for a new password when BreachedPassword finds theirs (NIST 3.1.1.2).
  • A new install's provider starts with the risk signals its features can feed, and registers the new device, failed second factor, suspicious activity and undone email change notices when their feature is on. A reset on a never-verified account now sends its notice.
  • support_contact: one setting, passed to every notification, shown in the published notices (NIST 4.6).
  • Keyring's own breach lookup follows no redirect (ASVS 15.3.2).
  • A refusal by the form limiter is logged as rate_limited, through a new RateLimited event (ASVS 16.3.3).
  • The browser helpers encode what they put in a path (ASVS 1.2.2).
  • present() gives createdAt and lastUsedAt, kept off the challenge page.
  • The conformance suite fails an app whose password broker has no throttle.
  • An entry written to the app's log carries its time with an offset (ASVS 16.2.2).

Docs

  • docs/owasp-asvs.md is rewritten from the code: the three ASVS levels, every V6 and V7 requirement, the requirements in other chapters that bear on the package, what Keyring's AAL1 to AAL3 mean in NIST's terms, and the cheat sheet recommendations that depend on setup.
  • docs/security.md: the Standards table has the right document, section and revision for each row, and Known Limitations states each deviation once with its reason.
  • Citations corrected across the docs, config comments and docblocks. CHANGELOG.md brought up to what the package does.

To test

composer check, and in js/: bun run typecheck && bun test. StandardsDocsTest pins what the ASVS page says about a default install to the config and the installer.

Not for merging yet: the example app needs a few changes for this, listed in the hand-over.

…ous activity and undone email change notices by default
@entity
entity merged commit bebe378 into main Nov 11, 2026
5 checks passed
@entity
entity deleted the feat/standards-close-out branch November 11, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant