Replace the experimental badge with a shorter unstable one - #600
Merged
Conversation
At 91px the experimental badge was half again as wide as the badges it sits beside - preview is 63, the version badge 64 - so it broke the line wherever it appeared. "unstable" renders at 66px, and says the same thing about an API: not settled, may change or be withdrawn. The sentences next to the badge in doc-code drop "experimental" for the same reason of consistency; the virtual-thread text already said "treat it as an experiment" and "not for production", which needs no change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HojPYKFnpQsNmRoMu3GD9c
There was a problem hiding this comment.
Pull request overview
This PR updates Enonic XP documentation to replace the wider experimental.svg inline badge with a shorter unstable.svg badge, avoiding unwanted line breaks where the badge is used inline.
Changes:
- Updated the virtual threads badge in the XP 8.1 release notes to use
unstable.svg. - Updated
threadPool.virtualThreadsandthreadPool.virtualThreads.maxConcurrentconfig reference entries to useunstable.svg. - Adjusted the
docs/images/unstable.svgasset to render the “unstable” label at the intended smaller width.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
docs/release.adoc |
Swaps the virtual-threads badge from experimental.svg to unstable.svg in the release notes. |
docs/images/unstable.svg |
Updates the SVG geometry/text to render the shorter “unstable” badge (66px wide). |
docs/config/system.adoc |
Replaces the experimental.svg badge with unstable.svg for the two virtual-threads config keys. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
experimental.svgrendered 91px wide — half again as wide as the badges it sits beside — so it broke the line wherever it appeared inline.experimental.svg(removed)unstable.svg(new)preview.svgxp-8010.svgSame generator, same shields.io geometry and Verdana metrics, same
#fe7d37orange — only the label is shorter. "unstable" says the same thing about an API: not settled, may change or be withdrawn.Three call sites:
threadPool.virtualThreadsandthreadPool.virtualThreads.maxConcurrentinconfig/system.adoc, and the virtual-threads entry in the 8.1 release notes. The prose is untouched — it already says "treat it as an experiment" and "not for production", which reads correctly under either badge.Paired with enonic/doc-code#81, which does the same swap there.
Generated by Claude Code