docs(notation): the notation page shows a named expression whose declared frame is wider than its body - #756
Merged
Merged
Conversation
…xpression with a declared frame `rating` declares `dims: [generator, snapshot]` over a body that carries only `generator`, and `under_rating` reads it over `[snapshot, generator]`. The golden output pins the frame as written and the broadcast along `snapshot`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W1VBZvT7UNJJexTrMX7mRi
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W1VBZvT7UNJJexTrMX7mRi
FBumann
enabled auto-merge (squash)
September 28, 2026 14:46
FBumann
pushed a commit
that referenced
this pull request
Sep 28, 2026
Brings #756. The changelog keeps both lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W1VBZvT7UNJJexTrMX7mRi
This was referenced Sep 28, 2026
Merged
FBumann
pushed a commit
that referenced
this pull request
Sep 28, 2026
Brings #742, #743, #756 and #759. Only CHANGELOG.md conflicted, and it keeps both sides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CQxVP5uX2V4rpvJNPhbyR2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
The golden model gains
rating, a plain named expression withdims: [generator, snapshot]over a body ingeneratoronly, andunder_rating, a row that reads it. The golden output and the notation page now pin #741's frame.What prints, the probe, gates, what was not done
What prints (markdown, the same in LaTeX and Typst):
tools/notation.pyplaces both entries under "Named expressions".docs/reference/notation.mdis regenerated. The nameratingis used because the model already has a constraint calledceiling, andtypeset_declarationrefuses a name that two sections declare.Probe. I removed the declared-frame branch from
lowering._frame_of, so a plain entry's frame came from its body again. All threetest_the_output_matches_the_committed_golden_filecases failed. Before this PR, no golden file changed under that mutation, because #741 left the golden model with no plain entry that hasdims:. The tree was restored withgit checkout --.Gates. Pixi cannot be installed in this container. In a Python 3.12
uvvirtualenv with the runtime pins pluspytest,pytest-xdistandcoverage, onorigin/mainat74c36d6:pyrefly checkreports 14 errors, all insrc/, which this PR does not touch. They come from import resolution in this venv (pydantic.config, theyamlstubs). Not run:docs-build,compile-tex,typos,reuse lint,zizmor,taplo.Not done. Nothing in
src/changed. The reference page on named expressions already documents the frame (#741).🤖 Generated with Claude Code
https://claude.ai/code/session_01W1VBZvT7UNJJexTrMX7mRi
Generated by Claude Code