Skip to content

docs(notation): the notation page shows a named expression whose declared frame is wider than its body - #756

Merged
FBumann merged 2 commits into
mainfrom
claude/happy-galileo-ovu6oo
Sep 28, 2026
Merged

FBumann merged 2 commits into
mainfrom
claude/happy-galileo-ovu6oo

Conversation

@FBumann

@FBumann FBumann commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Prompt: "Add the plain etry with dims to the golde model." — then "They are already merged. Should be a follow up PR"

Note

The following content was generated by AI.

The golden model gains rating, a plain named expression with dims: [generator, snapshot] over a body in generator only, and under_rating, a row that reads it. The golden output and the notation page now pin #741's frame.

What prints, the probe, gates, what was not done

What prints (markdown, the same in LaTeX and Typst):

legend      rating over 𝒢 × 𝒯                                   the frame as written, not in declaration order
definition  rating_{g,t} = eta_g · p^max_g   ∀ g ∈ 𝒢, t ∈ 𝒯     constant along t
row         p_{t,g} ≤ rating_{g,t}          ∀ t ∈ 𝒯, g ∈ 𝒢

tools/notation.py places both entries under "Named expressions". docs/reference/notation.md is regenerated. The name rating is used because the model already has a constraint called ceiling, and typeset_declaration refuses a name that two sections declare.

Probe. I removed the declared-frame branch from lowering._frame_of, so a plain entry's frame came from its body again. All three test_the_output_matches_the_committed_golden_file cases failed. Before this PR, no golden file changed under that mutation, because #741 left the golden model with no plain entry that has dims:. The tree was restored with git checkout --.

Gates. Pixi cannot be installed in this container. In a Python 3.12 uv virtualenv with the runtime pins plus pytest, pytest-xdist and coverage, on origin/main at 74c36d6:

pytest tests -n 8                         2072 passed, 30 skipped
ruff check . / ruff format --check .      clean (ruff 0.16.1)
prettier --check docs CHANGELOG.md examples mkdocs.yml   clean
python -m tests.typesetting.golden        regenerated, committed
python -m tools.notation --check          current
python -m tools.gallery --check           13 page(s) current
python -m tools.schema                    no diff

pyrefly check reports 14 errors, all in src/, which this PR does not touch. They come from import resolution in this venv (pydantic.config, the yaml stubs). Not run: docs-build, compile-tex, typos, reuse lint, zizmor, taplo.

Not done. Nothing in src/ changed. The reference page on named expressions already documents the frame (#741).

🤖 Generated with Claude Code

https://claude.ai/code/session_01W1VBZvT7UNJJexTrMX7mRi


Generated by Claude Code

…xpression with a declared frame

`rating` declares `dims: [generator, snapshot]` over a body that carries only
`generator`, and `under_rating` reads it over `[snapshot, generator]`. The
golden output pins the frame as written and the broadcast along `snapshot`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W1VBZvT7UNJJexTrMX7mRi
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W1VBZvT7UNJJexTrMX7mRi
@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 mathspec | 🛠️ Build #34805638 | 📁 Comparing 9c924c0 against latest (74c36d6)

  🔍 Preview build  

2 files changed
± changelog/index.html
± reference/notation/index.html

@FBumann
FBumann enabled auto-merge (squash) September 28, 2026 14:46
@FBumann
FBumann merged commit 8e4765a into main Sep 28, 2026
5 checks passed
FBumann pushed a commit that referenced this pull request Sep 28, 2026
Brings #756. The changelog keeps both lines.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W1VBZvT7UNJJexTrMX7mRi
FBumann pushed a commit that referenced this pull request Sep 28, 2026
Brings #742, #743, #756 and #759. Only CHANGELOG.md conflicted, and it keeps
both sides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CQxVP5uX2V4rpvJNPhbyR2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants