test(validation): the mistyped-lookup case declares its shape with dims - #460
Merged
Merged
Conversation
This case still declared the constraint's shape with `foreach`, so the closed schema refused it for an unknown key before the `where` lookup was ever resolved, and the assertion on the lookup listing never ran. It now declares `dims`, like every other case in the block, and reaches the "'lkk' not found / Lookups: ['lk']" refusal it is written for. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015VTJgAdeTzXM6gRCW39VNT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
What this changes
One parametrize case in
tests/test_validation.pystill declared a constraint's shape withforeach. It now declaresdims, like the other eight cases in the block. This turnsmain's CI green, and with it the red CI on the release PR #459 (which only bumps the version).Why
#429 renamed a constraint's shape key from
foreachtodimsbut missed this case, so the closed schema refused it forunknown key 'foreach'before thewherelookup was resolved — and the assertion the case exists for ('lkk' not found/Lookups: ['lk']) never ran. CI has been red onmainsince #429 merged.Verified:
tests/test_validation.pypasses all 239 (Python 3.13, runtime deps installed by hand). Did not run the fullpixi run cigate —pixi.shis blocked by this environment's egress proxy, so pixi could not be installed.The failure on the broken tree, and the fix
CI on both
mainand #459:The change:
After it, run directly (pixi unavailable):
foreachappears nowhere else as a stale key — the only other occurrence is the test nametest_the_emitted_foreach_follows_declaration_order, about the mathematical∀, whose body already usesdims.🤖 Generated with Claude Code
https://claude.ai/code/session_015VTJgAdeTzXM6gRCW39VNT
Generated by Claude Code