Repository navigation
test: nothing the model is given prints italic, asked of the whole page - #46
Merged
Merged
Conversation
The convention had per-name tests and byte-for-byte goldens, and neither says
*nothing else* prints a given quantity italic. A rendering path added later
reaches the page through its own call: the derivation tests would still pass,
the goldens would be regenerated to match, and the first to notice the leak
would be a reader rather than the suite.
So this asks the finished document, over the fixture that carries every
construct: every `\mathit` on the page names a variable, and every parameter
symbol the derivation produced is upright. Multi-letter names land in the
first net and single letters in the second, which is where `\mathrm{p}` sits.
Checked against a plausible regression rather than assumed — a `given` test
narrowed to single letters puts nine parameters back in italic, and the test
names all nine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #44, which introduced the convention but tested it only where someone thought to name a symbol.
What was missing
#44 left two kinds of guard on upright is what the model is given, italic is what the solver chooses: per-name tests over
_derive_name_symbol, and the goldens byte-for-byte. Neither says nothing else prints a given quantity italic.A rendering path added later reaches the page through its own call. The derivation tests would still pass, the goldens would be regenerated to match the new output, and the first to notice the leak would be a reader — which is the failure mode the notation page exists to prevent.
What this asks instead
The finished document, over the fixture that carries every construct:
plus the derivation side, that every parameter symbol in that model is upright. Multi-letter names land in the first net; single letters land in the second, which is where$\mathrm{p}$ sits — a bare italic
pfor a parameter would otherwise be invisible to a text search, since an index letter looks the same.Checked, not assumed
Against a plausible regression rather than a contrived one: narrowing the
giventest to single letters — the shape a careless refactor takes — puts nine parameters back in italic, and the test names all nine:Checks
pixi.shis unreachable from this environment, so the gates ran on a 3.13 venv at the versionspixi.tomlpins: 383 passed,ruffcheck and format clean,pyrefly0 errors,typosclean. No generated output changes — this adds a test and nothing else.Generated by Claude Code