docs(language): only a dimension some declaration reaches needs a source - #378
Merged
Merged
Conversation
The rule as merged in #242 said a dimension nothing supplies is an error, with no qualifier. A declared dimension no declaration reaches builds and solves in lpspec today, so the rule was stricter than any implementation of it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013a3tFCULeY7Skmkhbxpj7V
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
#242 landed the binding rules with one of them stated too strongly:
No qualifier. A declared dimension that no declaration reaches builds and solves in lpspec today — the reviewer probed one — and a dimension a declaration does span is refused there correctly. So the rule as written was stricter than either implementation of it, which is the worst way for a page like this to be wrong: it is the normative text, and a consumer written to it would refuse working models.
Now:
The second sentence is added rather than implied. The rule's whole point is that a consumer implements it instead of choosing, so the case it does not cover should not be left to be inferred from the absence of a clause.
Verified
pixi run lintandpixi run docs-build(mkdocs build --strict) pass in a clean worktree at basebbecc71.Not run:
testandcompile-tex— the diff is one paragraph of prose indocs/, and no generated page reads it.tests/test_docs.pycovers the generated pages, and this is not one.Scope: the wording only. The other findings from the same review land on #245, which is where the
coverage:guard they concern lives.Generated by Claude Code