version 1.0.0

[end41r]

No description provided.

[end41r]

Since the development and testing in this branch were made concurrently, there is no need for a review. But I'm asking copilot for just in case

[end41r]

Server side CI check failed because alsa is missing, no time to change that, locally all the checks passed

[Copilot]

Pull request overview

This PR bumps the project to v1.0.0 / Rust 2024 and introduces major gameplay UI upgrades (avatars, scoreboard, audio), along with new animation behavior and assorted refactors across client/server.

Changes:

• Add avatars + shard animations to the table UI and introduce a new scoreboard UI (including game-end board).
• Add a Rodio-based audio system (music + SFX) with an Options menu for volume control.
• Refactor gameplay rendering into a GameView and update related message routing/animation helpers.

Reviewed changes

Copilot reviewed 38 out of 93 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/ui_element_traits.rs	Adds ResizableDynHeight trait used by the scoreboard layout.
src/server.rs	Assigns random avatar kinds to players and minor cleanup.
src/main.rs	Small comment change (typo introduced).
src/gameplay_ui/mod.rs	Introduces GameView and routes gameplay messages; adds end-game overlay behavior.
src/gameplay_ui/table/mod.rs	Adds avatar rendering and avatar-related messages/SFX.
src/gameplay_ui/table/avatar.rs	New avatar UI element with animations, shards, and click interactions.
src/gameplay_ui/scoreboard.rs	New scoreboard UI + bidding/trump selection panels and end-game board view.
src/gameplay_ui/table/middle/card_stack/*	New played-cards history interactions/animations and SFX hooks.
src/gameplay_ui/table/middle/card_deck/*	Refactors glow + trump-card animations and adds SFX.
src/gameplay_ui/hand/*	Refactors hand/card interaction to be message-based (Card) rather than index-based; adds SFX and turn gating.
src/client/audio.rs	New audio subsystem (music + SFX loading/playback + volume control).
src/client/views/*	Adds Options menu, rewires gameplay rendering, adds disconnect banner.
src/api.rs	Adds Avatar types, TextColor helper, Card::img_path()/glow_path(), and ServerMessage::ConnectionClosed.
src/animation.rs	Renames/adjusts animation core fields and adds new “reached” callbacks + infinite-start helpers.
rust-toolchain.toml	Pins toolchain to 1.90.0.
Cargo.toml	Version bump to 1.0.0, edition 2024, adds rodio.
DOCUMENTATION.md / README.md / REQUIREMENTS.md	Documentation updates for running/building and project requirements.

Comments suppressed due to low confidence (9)

src/main.rs:1

• Typo in comment: "widndow" should be "window".
  src/gameplay_ui/table/mod.rs:88
• self.find_avatar(player).unwrap() will panic if an AvatarMessage::PlayShard is received for an id that isn't present in self.avatars (e.g., desync/reconnect timing). Please handle the None case gracefully (skip SFX, log, etc.) instead of unwrapping.
  src/gameplay_ui/table/middle/card_deck/glow_card.rs:70
• CardStackGlow's glow_animation is never started, so glow_animation.next_frame() won't animate and the glow opacity stays static. Consider starting it in new() (e.g., via start_infinite()) or when a glow is first shown.
  src/api.rs:361
• Card::glow_path() returns the literal string "NOT VALID" for wizards. This will still be passed to iced::widget::image(...) and may result in failed asset loading/log spam (or worse, depending on image loading behavior). Prefer returning an empty string/Option and skipping the glow image when no glow should be shown.
  REQUIREMENTS.md:27
• Docs/tooling disagree on required Rust toolchain version: REQUIREMENTS.md says rustc 1.85.0, but the repo pins 1.90.0 in rust-toolchain.toml and DOCUMENTATION.md mentions enforcing 1.90.0. Please align these (either update the requirement doc or pin to 1.85.0).

- [ ] **(C1) The project must be compilable with rustc stable 1.85.0 (edition=2024).**

DOCUMENTATION.md:43

• Grammar issue: "Unit are located" should be "Unit tests are located" (or similar).

Unit are located in `src/gamelogic/game.rs` (UI testing was done differently).

src/ui_element_traits.rs:55

• Doc comments for the new ResizableDynHeight trait contain multiple typos (e.g., "Implmenet", "interference", "an resize", "occures"), which makes the API docs harder to read. Please correct the spelling/grammar.
  src/gameplay_ui/table/mod.rs:59
• build_avatars appends to self.avatars without clearing it first. If StartGame (or similar) can be triggered more than once (reconnect/new game), this will duplicate avatars and break indexing/layout. Consider clearing self.avatars before pushing, or rebuilding from scratch.
  src/client/views/menu.rs:39
• The disconnected banner sets .color(red) and then calls .white(), which overrides the red color and makes the warning not red. Remove the .white() call (or apply .white() only where no explicit color is set).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.