chore: update dependencies#26
Merged
Merged
Conversation
Resolves the unmaintained serde_cbor (RUSTSEC-2021-0127) and atty unsoundness (RUSTSEC-2021-0145) advisories surfaced via criterion 0.3. The rand 0.8 to 0.10 and getrandom 0.2 to 0.4 bumps from issue #25 are left out: pg-curve / pairing / group / ff still depend on rand_core 0.6, so passing a rand 0.10 RngCore to Group::random and friends does not typecheck. The wasm32 getrandom direct dep only exists to enable the js feature on the transitive 0.2 used through rand_core 0.6, so bumping it in isolation has no effect. Update criterion's deprecated black_box re-export to std::hint::black_box.
rubenhensen
approved these changes
May 7, 2026
This was referenced May 7, 2026
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25.
What changed
criterion0.3.6 -> 0.8.2 (dev-dependency).criterion::black_boxre-export withstd::hint::black_boxinbenches/main.rs.This resolves the two security advisories pulled in transitively through
criterion 0.3:serde_cbor 0.11.2unmaintained (RUSTSEC-2021-0127)atty 0.2.14unsound (RUSTSEC-2021-0145)What was left out and why
The other bumps listed in #25 form one ecosystem-wide knot and cannot be applied here:
rand0.8 -> 0.10 —pg-curve 0.2,pairing 0.23,group 0.13, andff 0.13all depend onrand_core 0.6. The crate calls into them withGroup::random(&mut rng)etc., which expect an&mut R: RngCore + CryptoRngfromrand_core 0.6.rand 0.10shipsrand_core 0.10, whose traits are a separate, incompatible type. Bumpingrandhere causeserror[E0432]: unresolved import rand::RngCoreand trait-bound mismatches at every call site. This needs the BLS curve stack (group/ff/pairing/pg-curve) to upgrade first.getrandom0.2 -> 0.4 — thewasm32-unknown-unknowndirect dep ongetrandom = "0.2", features = ["js"]exists solely to enable thejsfeature on thegetrandom 0.2that is pulled in transitively viarand_core 0.6. Switching the direct dep to 0.4 adds a parallel copy without affecting the version that's actually used, so it's deferred untilrandcan be bumped.I'd suggest filing a follow-up issue tracking the
rand_core 0.6->0.10migration oncepg-curve/ upstreamgroupships compatible releases.Verification
cargo build --all-featurescargo test --all-features-> 17 passedcargo bench --no-run --all-featurescargo clippy --all-targets --all-features-> cleancargo fmt --all -- --checkReviewer quickstart
`git fetch origin && git checkout chore/update-dependencies && cargo test --all-features`