ci: bump actions/checkout to v4 and add clippy lint job#22
Merged
Conversation
Move all jobs off the deprecated Node 16 runner (checkout@v3) onto v4, and add a Clippy job so new lints are caught in CI. Issue #16's cleanup already landed, so the run uses the default warning behavior; tightening to `-D warnings` can follow as a separate change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkout@v3→@v4across all three jobs (lint,test,no-std) to move off the deprecated Node 16 runner.clippyjob runningcargo clippy --all-features --all-targetsso new lints are caught in CI.Closes #15.
Notes
-D warningsbecause the tree had 17 pre-existing warnings. Since Clippy cleanup: 17 warnings on stable (cosmetic) #16 (the clippy cleanup) has already merged,cargo clippy --all-features --all-targetsnow runs cleanly. The job is left without-D warningsfor now; tightening to-- -D warningscan be a follow-up so a lint regression doesn't silently slip in.Test plan
cargo fmt -- --check— passescargo clippy --all-features --all-targets— clean (no warnings, no errors)cargo test --release --all-features— 17/17 passing locally