Texture loading fixes#170
Merged
encounter merged 14 commits intoMay 13, 2026
Merged
Conversation
Fixes encounter#119 For arb textures it's just making sure the file parsing can handle them. Idk if we need to do something special for it.
encounter
reviewed
May 10, 2026
Some of Henriko's textures (like the cuttable grass) rely on this. The mipmap bool is no longer part of the runtime key.
Might as well? Helped me debug some stuff
Contributor
Author
|
Well this works now. We still need to figure out how to make the build work though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119
For arb textures it's just making sure the file parsing can handle them. Idk if we need to do something special for it.
Note I did not, at all, attempt to fix the build to locate
zlibcorrectly. I have no idea how to, and if it were up to me I'd just say throw everything out use vcpkg.