Skip to content

Validation flag#63

Open
k1000dai wants to merge 6 commits into
enactic:mainfrom
k1000dai:validation_flag
Open

Validation flag#63
k1000dai wants to merge 6 commits into
enactic:mainfrom
k1000dai:validation_flag

Conversation

@k1000dai

Copy link
Copy Markdown
Contributor

#61

Adding the valid/invalid information per episode when validating.
Also, added the new flag '--valid-only' in order to remove the invalid data.

Copilot AI review requested due to automatic review settings July 22, 2026 06:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Comment thread src/openarm_dataset/metadata.py Outdated
Comment thread src/openarm_dataset/metadata.py Outdated
Comment thread src/openarm_dataset/dataset.py Outdated
- Add dict-like Episode class with Episode.valid()
- Extract validation logic into Validator class
- Disable valid flag write feature for unversioned datasets

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LYnRMrL29hDAgjePm2DgZJ
Copilot AI review requested due to automatic review settings July 23, 2026 14:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Without this, merging validated datasets dropped the per-episode valid
flag, so a later convert --valid-only would include episodes already
known to be invalid.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LYnRMrL29hDAgjePm2DgZJ
Copilot AI review requested due to automatic review settings July 23, 2026 14:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 24, 2026 05:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot AI review requested due to automatic review settings July 24, 2026 05:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants