Repository navigation
Conversation
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes/implements the following bugs/features
Documentation Update
Props and usage notes are in
link-group.component.yml. The button display only looks like buttons; every item is still a link.How to review this PR
npm run developand open Components → Link Group in Storybook.buttonand Background color on, the links sit in a white box that hangs below a colored band. Turn Background color off: only the buttons show.boxes. Check the two-column grid, the arrow on each box, and that the whole box is clickable.npm run lint.Boxes:
Button with bg-color:
Button without bg-color:
Accessibility
icon_labelis set. Hover motion is off withprefers-reduced-motion.Closes issues
https://fourkitchens.clickup.com/t/36718269/EMULSIF-577