Skip to content

EMULSIF-578: Create Embed component - #186

Open
mariannuar wants to merge 1 commit into
mainfrom
EMULSIF-578
Open

mariannuar wants to merge 1 commit into
mainfrom
EMULSIF-578

Conversation

@mariannuar

@mariannuar mariannuar commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Create Embed component

How to review this pull request

  • Confirm the default view renders a heading, intro text, a 16:9 responsive YouTube embed, and a caption
  • Open the Controls panel and check each control updates the preview live:
      - [ ] Embed source - switch between YouTube / Vimeo / OpenStreetMap / Mock widget
      - [ ] Aspect ratio - 16-9, 4-3, 1-1, and custom (paired with the "Custom ratio" field, e.g. 21 / 9)
      - [ ] Container width - compressed vs. full should visibly narrow/widen the component
      - [ ] Container alignment, Container theme, Container background
      - [ ] Clear Heading, Introductory text, and Caption - confirm no empty heading/intro/caption wrapper is left in the markup (inspect via devtools)
  • Resize the browser / use Storybook's viewport toolbar to confirm the embed stays responsive at mobile widths
  • Tab through the page with keyboard only - focus should reach the iframe, and its focus outline should not be clipped by the wrapper

Code review:

  • src/components/embed/embed.twig - confirm embed_content is documented as unsanitized/raw, and the embed_content block override exists for template-authored markup
  • src/components/embed/embed.scss - confirm aspect-ratio is done in pure CSS (no JS removing iframe width/height) and there's no overflow: hidden clipping focus/fullscreen
  • src/components/embed/README.md - review the trust-boundary / sanitization-responsibility documentation for accuracy
  • src/components/embed/embed.component.yml - confirm props match what's used in embed.twig

Accessibility

@netlify

netlify Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 99572da
🔍 Latest deploy log https://app.netlify.com/projects/emulsify-ui-kit/deploys/6ab9f47a24a37400082957e5
😎 Deploy Preview https://deploy-preview-186--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mariannuar mariannuar self-assigned this Sep 28, 2026
@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Sep 28, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👍 Ready for Review Work is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant