Repository navigation
EMULSIF-578: Create Embed component - #186
Open
mariannuar wants to merge 1 commit into
Open
mariannuar wants to merge 1 commit into
mariannuar wants to merge 1 commit into
Conversation
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create Embed component
How to review this pull request
- [ ] Embed source - switch between YouTube / Vimeo / OpenStreetMap / Mock widget
- [ ] Aspect ratio - 16-9, 4-3, 1-1, and custom (paired with the "Custom ratio" field, e.g.
21 / 9)- [ ] Container width - compressed vs. full should visibly narrow/widen the component
- [ ] Container alignment, Container theme, Container background
- [ ] Clear Heading, Introductory text, and Caption - confirm no empty heading/intro/caption wrapper is left in the markup (inspect via devtools)
Code review:
src/components/embed/embed.twig- confirmembed_contentis documented as unsanitized/raw, and theembed_contentblock override exists for template-authored markupsrc/components/embed/embed.scss- confirm aspect-ratio is done in pure CSS (no JS removing iframewidth/height) and there's nooverflow: hiddenclipping focus/fullscreensrc/components/embed/README.md- review the trust-boundary / sanitization-responsibility documentation for accuracysrc/components/embed/embed.component.yml- confirm props match what's used inembed.twigAccessibility