Don't use a launcher for bootstrap.py. NFC#27060
Open
sbc100 wants to merge 1 commit into
Open
Conversation
This script is only supposed to be run by folks using emscripten via a git checkout. Since the boostrap script it self creates all the launcher programs we have chicken and egg situation where we would need to keep these launchers in source control just for this one script. Instead, I think we can just say that using emscripten from git checkout requires the running on the python a script.
sbc100
force-pushed
the
bootstrap_no_laucnher
branch
from
b5b16ba to
1404dc6
Compare
dschuff
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script is only run by folks using emscripten via a git checkout.
Since the boostrap script it self creates all the launcher programs we have
chicken and egg situation where we would need to keep these launchers
in source control just for this one script.
Instead, I think we can just say that using emscripten from a git checkout
requires the running this as a normal python script.