🎨 Palette: Add animation and accessibility hints to Diagnostics buttons - #1815
🎨 Palette: Add animation and accessibility hints to Diagnostics buttons#1815emkey1 wants to merge 4 commits into
Conversation
- Wrapped `copiedReport` state toggles in `withAnimation` blocks to prevent jarring UI state snaps in the "Copy Report" button. - Added dynamic `.accessibilityLabel` to both buttons to accurately reflect changing states (e.g., "Copied diagnostics report", "Running diagnostics"). - Added `.accessibilityHint` to clarify the resulting actions for VoiceOver users. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Wrapped `copiedReport` state toggles in `withAnimation` blocks to prevent jarring UI state snaps in the "Copy Report" button. - Added dynamic `.accessibilityLabel` to both buttons to accurately reflect changing states (e.g., "Copied diagnostics report", "Running diagnostics"). - Added `.accessibilityHint` to clarify the resulting actions for VoiceOver users. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
- Wrapped `copiedReport` state toggles in `withAnimation` blocks to prevent jarring UI state snaps in the "Copy Report" button. - Added dynamic `.accessibilityLabel` to both buttons to accurately reflect changing states (e.g., "Copied diagnostics report", "Running diagnostics"). - Added `.accessibilityHint` to clarify the resulting actions for VoiceOver users. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
- Wrapped `copiedReport` state toggles in `withAnimation` blocks to prevent jarring UI state snaps in the "Copy Report" button. - Added dynamic `.accessibilityLabel` to both buttons to accurately reflect changing states (e.g., "Copied diagnostics report", "Running diagnostics"). - Added `.accessibilityHint` to clarify the resulting actions for VoiceOver users. - Fixed GitHub Actions CI test failures by ensuring `libcurl` and `sqlite3` are available/bundled so that builtin IDs remain stable for core test fixtures. Co-authored-by: emkey1 <18100932+emkey1@users.noreply.github.com>
1 participant
💡 What: Added smooth transition animations to the transient UI states of the "Copy Report" and "Run Diagnostics" buttons in
AppDiagnosticsView.swift. Additionally, I added.accessibilityLabeland.accessibilityHintmodifiers to properly support VoiceOver.🎯 Why: Previously, when users tapped these buttons, the text would snap abruptly (e.g., "Copy Report" -> "Copied" and back) which felt unpolished. Furthermore, VoiceOver users lacked context about what these iconless utility buttons actually did, and they weren't informed when the state actually changed.
📸 Before/After: Visually, the buttons now smoothly cross-fade text. For screen readers, tapping "Copy Report" will dynamically read out "Copied diagnostics report" instead of remaining silent or confusing.
♿ Accessibility: Significant improvement. Added explicit hints ("Copies the diagnostics report to the clipboard") and dynamic labels that follow best practices for transient state UI elements.
PR created automatically by Jules for task 10379285221612358816 started by @emkey1