Feature/fe add unit tests for transaction filter sidebar#864
Merged
emdevelopa merged 3 commits intoJun 2, 2026
Merged
Conversation
|
@Thosine-01 is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Thosine-01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #790
What this PR does
Adds a comprehensive unit test suite for the
TransactionFilterSidebarcomponent as part of the UX enhancement initiative. Also includes two small accessibility fixes to the component that were required to make the tests correct and meaningful.Changes made
frontend/src/components/TransactionFilterSidebar.test.tsx@testing-library/reactwithvitestandjsdomfrontend/src/components/TransactionFilterSidebar.tsxTwo accessibility patches were required:
aria-label="Clear search"to the clear-search button — it previously had no accessible label, making it untestable and inaccessible to screen readersaria-hidden="true"to theSyncSpinnerwrapper span inside asset buttons — without this, the spinner text was concatenated into the button's accessible name (e.g."XLMSyncing…"instead of"XLM"), which is both a test failure and an a11y bugTest coverage breakdown
searchSyncPendingstate,isFilterPendingstate, combinedanyPendingstate, aria-busy, dashed borders, opacity, hint text, aria-liveTest results