Skip to content

fix(admin): preserve EmDash footer product attribution#2046

Draft
logelog wants to merge 1 commit into
emdash-cms:mainfrom
logelog:fix/admin-footer-product-attribution
Draft

fix(admin): preserve EmDash footer product attribution#2046
logelog wants to merge 1 commit into
emdash-cms:mainfrom
logelog:fix/admin-footer-product-attribution

Conversation

@logelog

@logelog logelog commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Keeps the admin sidebar footer tied to the EmDash product identity instead of replacing it with a site's configured white-label name.

The configured site name still belongs in the admin header. The footer now deterministically renders EmDash CMS v<version> (<commit>), with a stable version fallback when build metadata is unavailable.

Root cause: the footer reused manifest.admin.siteName, which is site branding rather than CMS product attribution.

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: not applicable (bug fix)

Screenshots / test output

  • @emdash-cms/admin typecheck (tsgo --noEmit): passed
  • Targeted Oxlint on the changed TypeScript files: 0 warnings, 0 errors
  • Oxfmt check on the changed TypeScript files: passed
  • git diff --check: passed
  • Added two focused formatAdminFooter regression tests. The local browser runner could not execute them because this isolated worktree has stale Vitest 4.1.5 dependencies while the current lockfile expects @vitest/browser 4.1.9; the draft PR CI will run from a clean install.

The diff contains no site-specific branding or private plugin code.

@changeset-bot

changeset-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 946991b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/sandbox-workerd Patch
@emdash-cms/plugin-mcp-smoke Patch
@emdash-cms/fixture-perf-site Patch
@emdash-cms/perf-demo-site Patch
@emdash-cms/cache-demo-site Patch
@emdash-cms/do-demo-site Patch
@emdash-cms/do-solo-demo-site Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
create-emdash Patch
@emdash-cms/auth-atproto Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@logelog

logelog commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@logelog
logelog force-pushed the fix/admin-footer-product-attribution branch from 534c086 to a72d631 Compare July 15, 2026 05:19
@logelog
logelog force-pushed the fix/admin-footer-product-attribution branch from a72d631 to 763de8a Compare July 15, 2026 14:52
@github-actions github-actions Bot added size/XL and removed size/S labels Jul 15, 2026
@logelog
logelog force-pushed the fix/admin-footer-product-attribution branch from 763de8a to 40e8c84 Compare July 15, 2026 14:53

@MA2153 MA2153 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would undo #705

@ascorbic

Copy link
Copy Markdown
Collaborator

recheck

@ascorbic

Copy link
Copy Markdown
Collaborator

I think the best is somewhere in between. Maybe don't replace it with the site name by default, but allow that as an option

@pkg-pr-new

pkg-pr-new Bot commented Jul 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@2046

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@2046

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@2046

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@2046

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@2046

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@2046

emdash

npm i https://pkg.pr.new/emdash@2046

create-emdash

npm i https://pkg.pr.new/create-emdash@2046

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@2046

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@2046

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@2046

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@2046

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@2046

@emdash-cms/registry-verification

npm i https://pkg.pr.new/@emdash-cms/registry-verification@2046

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@2046

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@2046

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@2046

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@2046

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@2046

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@2046

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@2046

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@2046

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@2046

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@2046

commit: 946991b

@ascorbic

Copy link
Copy Markdown
Collaborator

If somebody would like to make the change I suggested (a separate config option to replace the footer attribution) then that would be welcome

@logelog
logelog force-pushed the fix/admin-footer-product-attribution branch from 40e8c84 to 946991b Compare July 24, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants