fix(admin): preserve EmDash footer product attribution#2046
Draft
logelog wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 946991b The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
recheck |
logelog
force-pushed
the
fix/admin-footer-product-attribution
branch
from
July 15, 2026 05:19
534c086 to
a72d631
Compare
logelog
force-pushed
the
fix/admin-footer-product-attribution
branch
from
July 15, 2026 14:52
a72d631 to
763de8a
Compare
logelog
force-pushed
the
fix/admin-footer-product-attribution
branch
from
July 15, 2026 14:53
763de8a to
40e8c84
Compare
MA2153
suggested changes
Jul 15, 2026
Collaborator
|
recheck |
Collaborator
|
I think the best is somewhere in between. Maybe don't replace it with the site name by default, but allow that as an option |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Collaborator
|
If somebody would like to make the change I suggested (a separate config option to replace the footer attribution) then that would be welcome |
logelog
force-pushed
the
fix/admin-footer-product-attribution
branch
from
July 24, 2026 19:27
40e8c84 to
946991b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keeps the admin sidebar footer tied to the EmDash product identity instead of replacing it with a site's configured white-label name.
The configured site name still belongs in the admin header. The footer now deterministically renders
EmDash CMS v<version> (<commit>), with a stable version fallback when build metadata is unavailable.Root cause: the footer reused
manifest.admin.siteName, which is site branding rather than CMS product attribution.Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.Screenshots / test output
@emdash-cms/admintypecheck (tsgo --noEmit): passedgit diff --check: passedformatAdminFooterregression tests. The local browser runner could not execute them because this isolated worktree has stale Vitest 4.1.5 dependencies while the current lockfile expects@vitest/browser4.1.9; the draft PR CI will run from a clean install.The diff contains no site-specific branding or private plugin code.