WarpDrive: Transactional Notification Delivery and Reactive Request State - #1236
Open
warpdrive-bot wants to merge 3 commits into
Conversation
This was referenced Sep 22, 2026
runspired
added a commit
to warp-drive-data/warp-drive
that referenced
this pull request
Sep 22, 2026
…Rs it opens (#11167) * rfc-sync: isolate per-RFC failures, document the required PR-creation setting The first real outbound run opened emberjs/rfcs#1236 successfully but then crashed opening the follow-up bookkeeping PR into this repo -- GitHub Actions is blocked from creating PRs here by a repo setting separate from the contents:write permission that let the branch push through. Because the whole script aborts on that error, RFC 2 never got a turn. Wrap each RFC's sync in its own try/catch so one failure doesn't block the rest, and document the missing "Allow GitHub Actions to create and approve pull requests" setting as required setup. * rfc-sync: use the bot's own token for PRs into this repo too, drop the Actions setting Opening a PR against a public repo doesn't require collaborator access on GitHub -- only pushing new commits to it or merging it does. Use EMBERJS_RFCS_SYNC_TOKEN for every PR this bot opens, including the follow-up bookkeeping PR into warp-drive-data/warp-drive, instead of asking for "Allow GitHub Actions to create and approve pull requests" repo-wide -- a much bigger grant (every workflow's default token, not just this one) than this feature actually needs. Neither workflow declares pull-requests: write anymore either.
runspired
added a commit
to warp-drive-data/warp-drive
that referenced
this pull request
Sep 22, 2026
Co-authored-by: 🤖 WarpDrive RFC Sync <332362369+warpdrive-bot@users.noreply.github.com>
This was referenced Sep 26, 2026
runspired
added a commit
to warp-drive-data/warp-drive
that referenced
this pull request
Sep 26, 2026
…ces them (#11287) docs: guide RFC authors to keep deprecations separate from feature RFCs Adds a subsection to the "Writing and Implementing RFCs" contributor skill stating that a feature and the deprecation of what it replaces belong in two separate RFCs -- the feature first, the deprecation as a follow-on that lands only once the replacement is Recommended. Captures review feedback on emberjs/rfcs#1236 (the transactional-notifications RFC), which mixed both.
runspired
added a commit
to warp-drive-data/warp-drive
that referenced
this pull request
Sep 26, 2026
rfc: deprecate subscription-based request state (RFC 0009) Splits the RequestStateService deprecation out of the transactional- notifications RFC (0001) into its own proposal, per review feedback on emberjs/rfcs#1236 that a feature and the deprecation of what it replaces belong in separate RFCs. Deprecates getRequestStateService / subscribeForRecord / getPendingRequestsForRecord / getLastRequestForRecord in favor of RFC 0001's signals-backed reactive request state, with the deprecation flag enabled only once that replacement is Recommended and removal targeted for 6.0. Claude-Session: https://claude.ai/code/session_017CMTUUPwpZXGjqCM8nUDrP Co-authored-by: Claude <noreply@anthropic.com>
runspired
added a commit
to warp-drive-data/warp-drive
that referenced
this pull request
Sep 26, 2026
) rfc: write the teaching guide into RFC 0001 and split out its deprecation Addresses review feedback on emberjs/rfcs#1236: - "How we teach this" now contains the actual guide prose (with examples), written for the docs "reactivity" section, instead of describing a guide to be written later. - The RequestStateService deprecation is removed from this RFC and referenced as separate RFC 0009; RFC 0001 now ships only the reactive replacement plus a compatibility shim, keeping the feature and its deprecation independent. sync-hash is left untouched for the sync bot to recompute on merge. Claude-Session: https://claude.ai/code/session_017CMTUUPwpZXGjqCM8nUDrP Co-authored-by: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened automatically from warp-drive-data/warp-drive's rfcs/0001-transactional-notification-delivery-and-reactive-request-state.md. See that file's history for full discussion prior to this PR.