sanitize javascript: urls in href on area elements#21443
Closed
rootvector2 wants to merge 1 commit into
Closed
Conversation
Contributor
|
shouldn't this go in #21442 ? |
Author
|
Yeah, makes sense. Moved the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The URL sanitizer in sanitized-values.ts lists A in badTags but not AREA. An in an image map navigates to its href on click just like an anchor, so with an attacker-controlled value reaches the DOM unsanitized and runs javascript:/vbscript: on click, while the identical is rewritten to unsafe:. Add AREA so the image-map link is treated like an anchor.