chore: issue 57 remove duplicated components

[gabrielfrasantos]

No description provided.

[Copilot]

Pull request overview

Removes duplicated Cortex-M interrupt/startup/reset utilities from hal_st and switches the STM32 drivers/examples to use the hal.cortex_m implementation from embedded-infra-lib, introducing a hal_st.bringup helper target to provide startup glue and deterministic weak-handler ordering.

Changes:

• Replace hal_st.cortex usage with hal.cortex_m across STM32 drivers, instantiations, examples, and integration tests.
• Remove duplicated components (InterruptCortex, SystemTickStm, ResetStm, TimeKeeperStm, default_init) and add hal_st/bringup to link required runtime/startup objects.
• Update standalone dependency pin for embedded-infra-lib and enable Cortex-M build only for ST cross-compiles; add end symbol in linker script for compatibility.

Reviewed changes

Copilot reviewed 63 out of 64 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
st/ldscripts/sections.ld	Expose additional linker symbol (end) at end of .noinit.
integration_test/tester/CMakeLists.txt	Switch tester target from default init to bringup.
integration_test/tested/CMakeLists.txt	Switch tested target from default init to bringup.
hal_st/synchronous_stm32fxxx/TimeKeeperStm.hpp	Remove duplicated TimeKeeper implementation.
hal_st/synchronous_stm32fxxx/TimeKeeperStm.cpp	Remove duplicated TimeKeeper implementation.
hal_st/synchronous_stm32fxxx/SynchronousUartStm.hpp	Update interrupt handler include/namespace.
hal_st/synchronous_stm32fxxx/CMakeLists.txt	Drop removed TimeKeeper sources from target.
hal_st/stm32fxxx/WatchDogStm.hpp	Switch to hal.cortex_m interrupt types.
hal_st/stm32fxxx/UsbHostLinkLayerStm.hpp	Switch to hal.cortex_m interrupt types/priority enum.
hal_st/stm32fxxx/UartStmDuplexDma.hpp	Adjust comment/type references for new interrupt namespace.
hal_st/stm32fxxx/UartStm.hpp	Switch to hal.cortex_m interrupt types/priority enum.
hal_st/stm32fxxx/TimerStm.hpp	Switch to hal.cortex_m interrupt types.
hal_st/stm32fxxx/TamperStm.hpp	Switch to hal.cortex_m interrupt types.
hal_st/stm32fxxx/SystemTickTimerService.hpp	Switch to hal.cortex_m interrupt base class.
hal_st/stm32fxxx/SystemTickTimerService.cpp	Replace direct SysTick register writes with cortex::SystemTick.
hal_st/stm32fxxx/SystemTickStm.hpp	Remove duplicated SysTick wrapper.
hal_st/stm32fxxx/SystemTickStm.cpp	Remove duplicated SysTick wrapper.
hal_st/stm32fxxx/SpiMasterStm.hpp	Switch to hal.cortex_m interrupt types.
hal_st/stm32fxxx/ResetStm.hpp	Remove duplicated Reset implementation.
hal_st/stm32fxxx/ResetStm.cpp	Remove duplicated Reset implementation.
hal_st/stm32fxxx/RandomDataGeneratorStm.hpp	Switch to hal.cortex_m interrupt base class.
hal_st/stm32fxxx/QuadSpiStmDma.hpp	Switch to hal.cortex_m dispatched interrupt handler.
hal_st/stm32fxxx/PkaStm.hpp	Switch base interrupt handler to hal.cortex_m.
hal_st/stm32fxxx/PkaStm.cpp	Update base-class constructor qualification for new namespace.
hal_st/stm32fxxx/LpTimerStm.hpp	Switch to hal.cortex_m interrupt types.
hal_st/stm32fxxx/I2cStm.hpp	Switch to hal.cortex_m interrupt types.
hal_st/stm32fxxx/GpioStm.hpp	Switch to hal.cortex_m interrupt types (multiple handlers).
hal_st/stm32fxxx/GpioStm.cpp	Update include to hal.cortex_m.
hal_st/stm32fxxx/FlashInternalStmBle.hpp	Switch to hal.cortex_m interrupt types.
hal_st/stm32fxxx/FlashInternalHighCycleAreaStm.hpp	Switch to hal.cortex_m interrupt types.
hal_st/stm32fxxx/EthernetMacStm.hpp	Switch to hal.cortex_m dispatched interrupt handler.
hal_st/stm32fxxx/DmaStm.hpp	Switch variants/handles to hal.cortex_m interrupt types.
hal_st/stm32fxxx/DmaStm.cpp	Update in-place variant/std::get types for new namespace.
hal_st/stm32fxxx/CMakeLists.txt	Link STM32 driver lib against hal.cortex_m; drop removed sources.
hal_st/stm32fxxx/CanStm.hpp	Switch to hal.cortex_m dispatched interrupt handlers.
hal_st/stm32fxxx/AnalogToDigitalPinStm.hpp	Switch to hal.cortex_m dispatched interrupt handler.
hal_st/stm32fxxx/AnalogToDigitalPinStm.cpp	Update include to hal.cortex_m.
hal_st/instantiations/TracingResetStm.hpp	Remove instantiation that depended on removed ResetStm.
hal_st/instantiations/TracingResetStm.cpp	Remove instantiation that depended on removed ResetStm.
hal_st/instantiations/StmEventInfrastructure.hpp	Update interrupt table type to hal::cortex::InterruptTable.
hal_st/instantiations/CMakeLists.txt	Drop removed TracingReset sources from target.
hal_st/default_init/DefaultInit.cpp	Remove duplicated runtime/syscall/assert/startup glue.
hal_st/default_init/CMakeLists.txt	Remove hal_st.default_init target and helper function.
hal_st/default_init/Atomic.cpp	Remove duplicated __atomic_* shims (now provided elsewhere).
hal_st/cortex/InterruptCortex.hpp	Remove duplicated Cortex interrupt abstraction.
hal_st/cortex/InterruptCortex.cpp	Remove duplicated Cortex interrupt abstraction.
hal_st/cortex/DataWatchpointAndTrace.hpp	Remove duplicated DWT wrapper.
hal_st/cortex/DataWatchpointAndTrace.cpp	Remove duplicated DWT wrapper.
hal_st/cortex/CMakeLists.txt	Remove hal_st.cortex library target.
hal_st/CMakeLists.txt	Replace cortex/default_init subdirs with bringup.
hal_st/bringup/CMakeLists.txt	Add bringup target and halst_target_bringup() helper with link-order rationale.
hal_st/bringup/Bringup.cpp	Add startup glue (HAL_InitTick, Default_Handler_Forwarded).
hal_st/bringup/Assert.cpp	Add assert hooks forwarding to std::abort().
examples/sesame/CMakeLists.txt	Switch example target from default init to bringup.
examples/helloworld/CMakeLists.txt	Switch example targets from default init to bringup.
examples/freertos/Main.cpp	Update interrupt table type to hal::cortex::InterruptTable.
examples/freertos/CMakeLists.txt	Switch example target from default init to bringup.
examples/blink/CMakeLists.txt	Switch example targets from default init to bringup.
CMakeLists.txt	Update embedded-infra-lib commit; enable Cortex-M components only for ST cross-compiles.
CLAUDE.md	Add pointer document to canonical agent rules.
AGENTS.md	Add canonical agent rules (style/constraints/build presets).
.ls-lint.yml	Ignore .claude directory in ls-lint.
.gitignore	Ignore .claude/scheduled_tasks.lock.
.claude/settings.json	Add agent permissions configuration (Bash allow-list).

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[gabrielfrasantos]

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Max errors	Warnings	Elapsed time
✅ ACTION	actionlint	5		0		0	0.06s
✅ CPP	clang-format	15	6	0		0	1.39s
✅ CPP	cppcheck	15		0		0	0.22s
✅ DOCKERFILE	hadolint	1		0		0	0.04s
✅ JSON	jsonlint	8		0		0	0.11s
✅ JSON	prettier	8	3	0		0	1.59s
⚠️ MARKDOWN	markdownlint	14	1	20		0	1.91s
✅ MARKDOWN	markdown-table-formatter	14	1	0		0	1.2s
✅ REPOSITORY	betterleaks	yes		no		no	0.85s
✅ REPOSITORY	checkov	yes		no		no	19.02s
✅ REPOSITORY	git_diff	yes		no		no	1.24s
✅ REPOSITORY	grype	yes		no		no	66.73s
✅ REPOSITORY	ls-lint	yes		no		no	0.01s
✅ REPOSITORY	osv-scanner	yes		no		no	0.97s
✅ REPOSITORY	secretlint	yes		no		no	6.06s
✅ REPOSITORY	syft	yes		no		no	1.86s
✅ REPOSITORY	trivy	yes		no		no	10.96s
✅ REPOSITORY	trivy-sbom	yes		no		no	0.43s
✅ REPOSITORY	trufflehog	yes		no		no	3.46s
⚠️ SPELL	lychee	41		6		0	23.44s
✅ YAML	prettier	8	1	0		0	1.99s
✅ YAML	v8r	8		0		0	4.81s
✅ YAML	yamllint	8		0		0	0.52s

Detailed Issues

⚠️ SPELL / lychee - 6 errors

📝 Summary
---------------------
🔍 Total..........263
🔗 Unique.........243
✅ Successful.....252
⏳ Timeouts.........0
🔀 Redirected.....111
👻 Excluded.........5
❓ Unknown..........0
🚫 Errors...........6
⛔ Unsupported......6

Errors in .github/agents/orchestrator.agent.md
[ERROR] file://.github/copilot-instructions.md (at 52:23) | File not found. Check if file exists and path is correct
[ERROR] file://hal_st/cortex/InterruptCortex.hpp (at 56:22) | File not found. Check if file exists and path is correct

Errors in .github/ISSUE_TEMPLATE/add-or-update-hal-driver.md
[ERROR] http://mcd.rou.st.com/modules.php?name=mcu (at 28:63) | Connection failed. Check network connectivity and firewall settings

Errors in CHANGELOG.md
[502] https://github.com/philips-software/amp-hal-st/commit/da44299e5c1354578329ce6d6a01bd31a1a348b6 (at 54:98) | Rejected status code: 502 Bad Gateway

Errors in README.md
[404] https://api.securityscorecards.dev/projects/github.com/embedded-pro/hal-st (at 3:199) | Rejected status code: 404 Not Found
[ERROR] https://st.com/ (at 5:93) | HTTP/2 protocol error. Server may not support HTTP/2 properly | Followed 1 redirect. Redirects: https://st.com/ --[301]--> https://www.st.com/

Hint: Followed 111 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`

⚠️ MARKDOWN / markdownlint - 20 errors

.github/agents/executor.agent.md:11 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the executor agent for..."]
.github/agents/orchestrator.agent.md:18:401 error MD013/line-length Line length [Expected: 400; Actual: 420]
.github/agents/orchestrator.agent.md:18 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the orchestrator agent..."]
.github/agents/planner.agent.md:11 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the planner agent for ..."]
.github/agents/planner.agent.md:39 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
.github/agents/reviewer.agent.md:14 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "You are the reviewer agent for..."]
.github/agents/reviewer.agent.md:122 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
.github/instructions/hal-st-cpp.instructions.md:18 error MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
.github/ISSUE_TEMPLATE/add-or-update-hal-driver.md:10 error MD025/single-title/single-h1 Multiple top-level headings in the same document [Context: "How to import a HAL driver"]
.github/prompts/orchestrate.prompt.md:8 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "Start a new development workfl..."]
CHANGELOG.md:83 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:87 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:94 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:103 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:122 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CHANGELOG.md:140 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "⚠ BREAKING CHANGES"]
CHANGELOG.md:144 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:151 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Features"]
CHANGELOG.md:162 error MD024/no-duplicate-heading Multiple headings with the same content [Context: "Bug Fixes"]
CLAUDE.md:1 error MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "hal-st — Claude Instructions"]

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: REPOSITORY_GITLEAKS, REPOSITORY_KICS. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

• Documentation: Custom Flavors
• Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CPPCHECK,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_LS_LINT,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

Show us your support by starring ⭐ the repository