fix: rename cpp image destination to gabrielfrasantos/embedded-devcontainer-cpp - #62
Conversation
Agent-Logs-Url: https://github.com/embedded-pro/embedded-devcontainer/sessions/c48a1a5c-d49d-4db9-af7b-886392f5bce6 Co-authored-by: gabrielfrasantos <21131318+gabrielfrasantos@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR standardizes the published Docker image name for the cpp flavor to gabrielfrasantos/embedded-devcontainer-cpp, and updates workflows, templates, and documentation to reference the new destination consistently across the repo.
Changes:
- Update CI workflows to use a uniform
gabrielfrasantos/embedded-devcontainer-${{ matrix.flavor }}naming pattern (removing thecppno-suffix special case). - Update devcontainer template/test references to pull
gabrielfrasantos/embedded-devcontainer-cpp. - Update documentation and templates to reflect the new cpp image name.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
templates/cpp/.devcontainer/Dockerfile |
Switch cpp template base image to embedded-devcontainer-cpp. |
README.md |
Update documented cpp image link to the -cpp repo. |
.github/workflows/vulnerability-scan.yml |
Scan the renamed cpp image using the unified naming pattern. |
.github/workflows/update-dependencies.yml |
Run dependency update jobs inside the renamed cpp image via the unified naming pattern. |
.github/workflows/build-push-test.yml |
Push cpp image to the renamed destination via the unified naming pattern. |
.github/RELEASE_TEMPLATE.md |
Update release template to reference the renamed cpp image identifier. |
.github/ISSUE_TEMPLATE/bug_report.md |
Update example container name to embedded-devcontainer-cpp. |
.github/copilot-instructions.md |
Update fork documentation to reflect cpp image now uses -cpp. |
.devcontainer/cpp-test/devcontainer.json |
Update cpp test devcontainer image reference to embedded-devcontainer-cpp. |
Test Results 12 files 12 suites 16m 40s ⏱️ Results for commit a69ab70. ♻️ This comment has been updated with latest results. |
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 24 | 0 | 0 | 0.24s | |
| ✅ DOCKERFILE | hadolint | 3 | 0 | 0 | 0.31s | |
| ✅ JSON | npm-package-json-lint | yes | no | no | 0.55s | |
| ✅ JSON | prettier | 22 | 1 | 0 | 0 | 0.85s |
| ✅ JSON | v8r | 22 | 0 | 0 | 12.45s | |
| ✅ MARKDOWN | markdownlint | 12 | 0 | 0 | 0 | 1.27s |
| ✅ MARKDOWN | markdown-table-formatter | 12 | 1 | 0 | 0 | 0.33s |
| ✅ REPOSITORY | checkov | yes | no | no | 25.64s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 1.37s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 51.86s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 2.01s | |
| ✅ REPOSITORY | syft | yes | no | no | 3.1s | |
| ✅ REPOSITORY | trivy | yes | no | no | 12.41s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.43s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 6.55s | |
| lychee | 86 | 3 | 0 | 11.63s | ||
| ✅ YAML | prettier | 32 | 0 | 0 | 0 | 1.29s |
| ✅ YAML | v8r | 32 | 0 | 0 | 12.8s | |
| ✅ YAML | yamllint | 32 | 0 | 0 | 1.16s |
Detailed Issues
⚠️ SPELL / lychee - 3 errors
[IGNORED] docker://pandoc/extra:3.9.0.0-ubuntu@sha256:72afa9c8d3300e5f10c9c4330e101725687f2179bffd912fb859c6d2ae85de62 | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.9.0.0-ubuntu@sha256:72afa9c8d3300e5f10c9c4330e101725687f2179bffd912fb859c6d2ae85de62)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[ERROR] https://docs.sigstore.dev/cosign/signing/overview/ | Network error: error sending request for url (https://docs.sigstore.dev/cosign/signing/overview/) Maybe a certificate error?
[ERROR] https://docs.sigstore.dev/cosign/verifying/verify/ | Network error: error sending request for url (https://docs.sigstore.dev/cosign/verifying/verify/) Maybe a certificate error?
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/embedded-pro/embedded-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/embedded-pro/embedded-devcontainer)
📝 Summary
---------------------
🔍 Total..........124
✅ Successful.....119
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........3
Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
Errors in README.md
[ERROR] https://docs.sigstore.dev/cosign/verifying/verify/ | Network error: error sending request for url (https://docs.sigstore.dev/cosign/verifying/verify/) Maybe a certificate error?
[ERROR] https://docs.sigstore.dev/cosign/signing/overview/ | Network error: error sending request for url (https://docs.sigstore.dev/cosign/signing/overview/) Maybe a certificate error?
See detailed reports in MegaLinter artifacts
You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:
- oxsecurity/megalinter/flavors/salesforce@v9.4.0 (58 linters)
- oxsecurity/megalinter/flavors/javascript@v9.4.0 (61 linters)
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
Show us your support by starring ⭐ the repository
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@copilot my job is faiiling due to docker hub limits: Error: buildx failed with: toomanyrequests: You have reached your pull rate limit as '***': dckr_jti_5XoGNCeg_5n9we0YC3GVxgAGJAI=. You may increase the limit by upgrading. https://www.docker.com/increase-rate-limit How can I fix that? |
That error means your authenticated Docker Hub account ( A single CI run on this repo pulls the base image ~16 times from Docker Hub: build matrix (cpp+rust × 2 archs = 4) + Practical options, cheapest first:
If you want, I can implement option 3 (push to both Docker Hub and GHCR, switch CI internals to GHCR) in a follow-up PR — that's the most durable fix and keeps your published artifacts on Docker Hub for end users. |
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
📦 Container Size AnalysisNote Comparing 📈 Size Comparison Table
|
|
🎉 Hooray! The changes in this pull request went live with the release of v7.0.1 🎉 |
The cpp container was being pushed to
gabrielfrasantos/embedded-devcontainer(no suffix) instead ofgabrielfrasantos/embedded-devcontainer-cpp, inconsistent with the-base/-rustnaming convention.Workflows
build-push-test.yml,vulnerability-scan.yml,update-dependencies.yml— removed thematrix.flavor == 'cpp'ternary special-case; all three now use the uniform pattern:gabrielfrasantos/embedded-devcontainer-${{ matrix.flavor }}Devcontainer & templates
.devcontainer/cpp-test/devcontainer.jsonandtemplates/cpp/.devcontainer/Dockerfile— updated image references togabrielfrasantos/embedded-devcontainer-cppDocumentation
README.md,.github/RELEASE_TEMPLATE.md,.github/ISSUE_TEMPLATE/bug_report.md— corrected all image name references.github/copilot-instructions.md— updated registry table, removed the "no suffix" rationale, updated required Docker Hub repos list