Serialized font improvements#53
Open
rfuest wants to merge 12 commits into
Open
Conversation
The size of a glyph's bitmap is stored as a u16 and the device width must be able to span the range of values.
Metrics is returned in the public trait ProportionalFont and should therefore also be public.
Contributor
|
Looks good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains various small improvements to the recently added serialized font support.
@iriswebb: Please take a look at these changes and let me know what you think. One important thing that is still missing is a end to end test, which converts a BDF font and draws some text using the converted font. When I tweaked the encoding of the glyph metadata in b039d37 I initially forgot to also adjust the serializer and there was no test to catch my error.