feat: add xAxisMaxItems (max lines) to line charts - #263
Open
jean-code-bot[bot] wants to merge 1 commit into
Open
feat: add xAxisMaxItems (max lines) to line charts#263jean-code-bot[bot] wants to merge 1 commit into
jean-code-bot[bot] wants to merge 1 commit into
Conversation
…bsPro Port the max-bars pattern from BarChartDefaultPro to the line charts. - Add `xAxisMaxItems` input to LineChartDefaultPro definition - Thread `xAxisMaxItems` prop through LineChartDefaultPro and LineChartWithKpiTabsPro components - Use `groupTailAsOther` in `getLineChartProData` to limit displayed points and roll the remainder into an 'Other' bucket - LineChartWithKpiTabsPro inherits the new input automatically via lineChartDefaultPro.meta spread - Add unit tests for maxItems behaviour in LineChartDefaultPro.utils
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the "max bars" pattern from
BarChartDefaultProto the line charts, giving users a Max x-axis items input to cap how many data points are rendered.What changed
LineChartDefaultProinputs.xAxisMaxItemsto the component inputs list (appears under Axes Settings)xAxisMaxItems?: numbertoLineChartProPropsmaxItems: xAxisMaxItemsintogetLineChartProDatagetLineChartProDatanow callsgroupTailAsOtherwithmaxItems— identical to howgetBarChartProDataworks — so excess items are rolled into an Other bucketLineChartWithKpiTabsPrometaspreadslineChartDefaultPro.meta)xAxisMaxItemsthrough togetLineChartProDataTests
LineChartDefaultPro.utils.test.tscoveringmaxItemsforwarding togroupTailAsOther