Fix numeric array save options being dropped in :memory and stream writes#214
Open
hlindset wants to merge 1 commit into
Open
Fix numeric array save options being dropped in :memory and stream writes#214hlindset wants to merge 1 commit into
hlindset wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric array save options (e.g.
background: [0, 128, 0]) were silently dropped on :memory and stream writes: the filename suffix string joined arrays with:(.jpg[background=0:128:0]), which libvips ignores. Arrays are now space separated (.jpg[background=0 128 0]). Flag lists like:keepstill use:. File-path writes were unaffected (they pass keyword params, not a suffix string). Looks like the option never worked: before the:join it was interpolated as charlist bytes.Adds regression tests for :memory and stream writes with a :background.