fix(flterm): keep Kitty replacements drawable - #107
Closed
adonm wants to merge 1 commit into
Closed
Conversation
Owner
|
Thanks, superded by #149 |
elias8
added a commit
that referenced
this pull request
Aug 18, 2026
Stabilize flterm’s Kitty graphics rendering by retaining ready images across unchanged frames and replacements, bounding and deduplicating asynchronous decode work, reusing pixel storage, and refreshing placement geometry when terminal dimensions change. This also replaces the allocating Kitty image pixel getter with a destination-required copy API across the native and Wasm libghostty bindings, with focused coverage for image lifetime, decode failure and backpressure, placement snapshots, resizing, and rendering behavior. Supersedes #107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Replacing an image previously removed the drawable immediately, producing blank frames and redundant decode work during rapid retransmission.
This is a two-file, independent extraction from #101.
Verification
flutter test test/rendering/kitty_image_cache_test.dart: 6 passeddart format --output=none --set-exit-if-changed packages/flterm: cleandart analyze packages/flterm: only the 3 existing info-level collection-style lints