fix(flterm): preserve tracked pointer and touch state - #106
Closed
adonm wants to merge 2 commits into
Closed
Conversation
Author
|
Addressed by the upstream interaction rewrite. Closing. Each gap this PR fixed is now covered on
The |
Author
|
Closing as addressed; see the comment above mapping each fix to the upstream commits that cover it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TouchMouseTracking.tapAndScroll: taps reach tracked terminal apps while touch/stylus drags remain local scrollingTouchMouseTracking.directas the compatibility defaultWhy
The previous path could fabricate
(0, 0)wheel positions, lose the pressed button, and forward touch drags as held left-button motion, causing applications such as Zellij to select text instead of scrolling.This is an independent extraction from #101, ported onto current
mainwithout the renderer-refactor commits.Verification
flutter testwith the supported prebuilt native-asset provider: 703 passeddart format --output=none --set-exit-if-changed packages/flterm: cleandart analyze packages/flterm: only the 3 existing info-level collection-style lints