refactor(flterm): consolidate renderer ownership - #103
Closed
adonm wants to merge 3 commits into
Closed
Conversation
Author
|
Superseded by the upstream controller/view refactors. Closing. What this PR proposed — consolidate frame buffers, painters, atlas state, Kitty state, paint ordering, and terminal dirtiness in the render pipeline — is now the upstream structure:
Happy to reopen a focused PR if a specific ownership gap remains after #143/#144 — otherwise this is covered. |
Author
|
Closing as superseded; see the comment above for the upstream commits that cover this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TerminalRenderPipelineown frame buffers, painters, atlas state, Kitty state, paint ordering, and terminal dirtinessTerminalViewbehaviorWhy
This removes duplicate ownership and synchronization paths from flterm. The adapter remains responsible for Flutter lifecycle and presentation while libghostty remains authoritative for terminal state.
This is an independent extraction from #101, replayed directly on current
main; it has no dependency on the other extracted PRs.Verification
flutter testwith the supported prebuilt native-asset provider: 686 passeddart format --output=none --set-exit-if-changed packages/flterm: cleandart analyze packages/flterm: only the 3 existing info-level collection-style lints