chore(site): drop Hyperfly + Brotli row from the benchmark - #20
Merged
Merged
Conversation
The benchmark now shows two Hyperfly rows instead of three: the schema-compiled layout, and the layout plus a trained dictionary. Three route notes quoted numbers that only existed as the difference against the removed row (39 B on events, 2 B on orders, 22 B on candles); those sentences go with it. The footnote that described the rows as "each adding one thing" is updated to the two that remain, and the now-unreachable `profile` bar kind is removed from the Row union and from globals.css. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the
Hyperfly + Brotlirow from the benchmark on the site. The chart now shows two Hyperfly rows: the schema-compiled layout, and the layout plus a trained dictionary.Copy that came with it. Three route notes quoted figures that only existed as the delta against the removed row, so those sentences are gone too:
/v1/events— "Brotli takes 39 bytes off this route… adding Brotli on top of the profiled stream makes it four bytes larger"/v1/orders/:id— "Brotli actually costs two bytes here rather than saving any"/v1/candles— "here the honest win still belongs to Brotli's 22 bytes"The section footnote described the Hyperfly rows as "each adding one thing: schema-compiled layout, then generic compression on top of it, then a dictionary" — now the two that remain. The
JSON + Brotli — edge q4rows and the footnote's "the Brotli rows are q4" are untouched.Also removes the
profilebar kind, now unreachable, from theRowunion and fromglobals.css.One thing worth a look before this ships. On
/v1/candlesthe removed row was the smallest number on the route — 362 B, against 384 B forHyperfly Profiled. It was the one place the page showed the profile not winning, and the note called that out as the honest read. Without it the chart reads as a clean sweep. Happy to leave it as-is, just flagging that it's the row with that property.check-typesandlintpass.🤖 Generated with Claude Code