feat(template)!: unify JS/TS templates#4229
Open
erickzhao wants to merge 26 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
erikian
previously requested changes
May 22, 2026
Co-authored-by: Erik Moura <erikian@electronjs.org>
… template-unification
Member
Author
|
@claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
The 3-line comment explaining "TypeScript magic constants" survives type stripping and appears in the generated JS output, referencing declarations that no longer exist. Remove it since the declare const lines are self-explanatory for TS users. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Member
Author
|
@claude review |
…int directive Move the "base does not support TypeScript" rejection into BaseTemplate.initializeTemplate (gated on the base templateDir) so it fires regardless of how the template was resolved, including the fully-qualified `@electron-forge/template-base` name that bypassed the string compare in init.ts. Switch webpack's main.ts to the ESM `import started from 'electron-squirrel-startup'` pattern that vite already uses. This removes the `// oxlint-disable-next-line @typescript-eslint/no-require-imports` directive that stripTypeScriptTypes preserved verbatim into the generated JS scaffold, where the referenced rule isn't even enabled. Adds @types/electron-squirrel-startup to the webpack TS devDeps (filtered out of the JS variant) so `tsc --noEmit` still passes. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
Member
Author
|
@claude review |
Member
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having separate packages for TypeScript-based templates is a burden. You need to duplicate any bundler-related template work, which leaves our templates open to drift.
This PR attempts to reconcile the two templates variants together, and to have
--typescriptas an instantiation option.The crux to this approach is that a lot of TypeScript files can be stripped by default in Node 22.13+ with
node:module'sstripTypeScriptTypesfunction.For app code: this works great.
For bundler-specific config: This works great for Vite, since it supports TS out of the box without additional configuration. For webpack, we still need to configure additional loaders, so the bundler configurations are kept separate for JS/TS.