feat(web-contents): add bypassCache option to navigationHistory.restore#52152
Draft
panther7 wants to merge 1 commit into
Draft
feat(web-contents): add bypassCache option to navigationHistory.restore#52152panther7 wants to merge 1 commit into
panther7 wants to merge 1 commit into
Conversation
Contributor
Author
|
Tested on Windows and 42-x-y branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
navigationHistory.restore()currently loads the restored entry viaLoadIfNecessary(), which serves the page from the HTTP cache without contacting the server. This means that conditions requiring a live network request — such as an expired or changed TLS certificate — are not re-evaluated and the corresponding events (e.g.certificate-error) are never fired.This PR adds an optional
bypassCacheboolean parameter (defaultfalse) tonavigationHistory.restore(). When set totrue, the restored entry is loaded viacontent::ReloadType::BYPASSING_CACHEinstead ofLoadIfNecessary(), forcing a fresh network request so that certificate errors and other network failures surface normally.Before:
After:
Checklist
npm testpassesRelease Notes
Notes: Added
bypassCacheoption tonavigationHistory.restore()to force a fresh network request when restoring navigation history, allowing certificate errors and other network failures to surface normally.