fix(core): CLI cookie warning headers already sent - #7
Closed
elcreator wants to merge 1 commit into
Closed
Conversation
The CLI installer includes index.php after it has already printed, so PHP considers the headers sent by the time the session settings are applied. Every CLI install therefore emitted four warnings: Warning: ini_set(): Session ini settings cannot be changed after headers have already been sent in index.php on line 86 Warning: ini_set(): Session ini settings cannot be changed after headers have already been sent in core/functions/session_proxy.php on line 61 Warning: session_id(): Session ID cannot be changed after headers have already been sent in core/functions/session_proxy.php on line 67 All of them address cookies and headers, which do not exist on CLI. Skip them there; $_SESSION is still filled by the merge that follows in EvoSessionProxy::init(), so nothing else changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RYzFvo3wBzPhLzhG4Dkzk2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI installer includes
index.phpafter it has already printed, so PHP considers the headers sent by the time the session settings are applied. Every CLI install (including the sqlite build that produces the nightly zip) emitted four warnings: