Add dedicated retention cap for archived index/search slowlogs - #1047
Open
ash9146 wants to merge 1 commit into
Open
Add dedicated retention cap for archived index/search slowlogs#1047ash9146 wants to merge 1 commit into
ash9146 wants to merge 1 commit into
Conversation
Slowlogs were not previously collected with their own retention cap, meaning archived search/indexing slowlogs competed with general *.log.gz archives under the shared maxLogs cap and could be evicted by unrelated log rotation. This adds a dedicated maxSlowLogs setting (default 3) and collects index_search_slowlog and index_indexing_slowlog archives independently, following the same pattern already used for maxGcLogs. Live slowlog files are already collected today with no opt-in flag, so this keeps the same always-on behavior and only changes the retention of archived files, rather than introducing a new flag. Verified manually against a running 8.15.0 node: created 5 dummy search slowlog archives, confirmed only the 3 most recent were collected.
|
💚 CLA has been signed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1046
Slowlogs were not previously collected with their own retention cap, meaning archived search/indexing slowlogs competed with general *.log.gz archives under the shared maxLogs cap and could be evicted by unrelated log rotation. This adds a dedicated maxSlowLogs setting (default 3) and collects index_search_slowlog and
index_indexing_slowlog archives independently, following the same pattern already used for maxGcLogs.
Live slowlog files are already collected today with no opt-in flag, so this keeps the same always-on behavior and only changes the retention of archived files, rather than introducing a new flag.
Verified manually against a running 8.15.0 node: created 5 dummy search slowlog archives, confirmed only the 3 most recent were collected.
Checklist